Re: [PATCH 17/24] drm/i915: Stash a pointer to the obj's resv in the vma

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 17/24] drm/i915: Stash a pointer to the obj's resv in the vma
Date: Fri, 19 May 2017 12:19:04 +0300	[thread overview]
Message-ID: <1495185544.3819.9.camel@linux.intel.com> (raw)
In-Reply-To: <20170518094638.5469-17-chris@chris-wilson.co.uk>

On to, 2017-05-18 at 10:46 +0100, Chris Wilson wrote:
> During execbuf, a mandatory step is that we add this request (this
> fence) to each object's reservation_object. Inside execbuf, we track the
> vma, and to add the fence to the reservation_object then means having to
> first chase the obj, incurring another cache miss. We can reduce the
>  number of cache misses by stashing a pointer to the reservation_object
> in the vma itself.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

<SNIP>

> +++ b/drivers/gpu/drm/i915/i915_vma.h
> @@ -50,6 +50,7 @@ struct i915_vma {
>  	struct drm_i915_gem_object *obj;
>  	struct i915_address_space *vm;
>  	struct drm_i915_fence_reg *fence;
> +	struct reservation_object *resv;

Add a kerneldoc that this is an alias.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx