From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove toplevel struct_mutex locking from debugfs/i915_drop_caches
Date: Thu, 25 May 2017 17:58:33 +0300 [thread overview]
Message-ID: <1495724313.3988.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170524162653.5446-1-chris@chris-wilson.co.uk>
On ke, 2017-05-24 at 17:26 +0100, Chris Wilson wrote:
> I have a plan to write a quick test to exercise concurrent usage of
> i915_gem_shrink(), the simplest way looks to be to have multiple threads
> using debugfs/i915_drop_caches. However, we currently take one lock over
> the entire function, serialising the calls into i915_gem_shrink() so
> reduce the lock coverage.
>
> Testcase: igt/gem_shrink/reclaim
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
<SNIP>
> + if (val & DROP_RETIRE)
> + i915_gem_retire_requests(dev_priv);
> +
> + mutex_unlock(&dev->struct_mutex);
> + }
>
> lockdep_set_current_reclaim_state(GFP_KERNEL);
Lock used to work as a serializer, isn't this going to get contended
now?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-25 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 16:26 [PATCH] drm/i915: Remove toplevel struct_mutex locking from debugfs/i915_drop_caches Chris Wilson
2017-05-24 16:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-25 14:58 ` Joonas Lahtinen [this message]
2017-05-25 15:03 ` [PATCH] " Chris Wilson
2017-05-30 8:42 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495724313.3988.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox