From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/glk: WA#0893: Also apply memory bw wa to Geminilake.
Date: Mon, 29 May 2017 11:26:05 +0300 [thread overview]
Message-ID: <1496046365.6086.4.camel@gmail.com> (raw)
In-Reply-To: <1495840982-3741-2-git-send-email-rodrigo.vivi@intel.com>
On Fri, 2017-05-26 at 16:23 -0700, Rodrigo Vivi wrote:
> According to spec this WA is needed for every gen9.
Actually GLK has a gen10 display, so the gen9 workarounds don't apply.
Ander
>
> Cc:Arthur Runyan <arthur.j.runyan@intel.com>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 5abeb3f..7a5f2e4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2904,9 +2904,8 @@ static inline struct scatterlist *__sg_next(struct scatterlist *sg)
> #define NEEDS_WaRsDisableCoarsePowerGating(dev_priv) \
> (IS_SKL_GT3(dev_priv) || IS_SKL_GT4(dev_priv))
>
> -/* WA#0893 */
> -#define NEEDS_WaIncreaseMemoryBW(dev_priv) (IS_GEN9_BC(dev_priv) || \
> - IS_BROXTON(dev_priv))
> +/* WA#0893: GEN9:ALL */
> +#define NEEDS_WaIncreaseMemoryBW(dev_priv) (IS_GEN9(dev_priv))
>
> /*
> * dp aux and gmbus irq on gen4 seems to be able to generate legacy interrupts
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-29 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 23:23 [PATCH 1/3] drm/i915: Wa#0893 is defined per platform Rodrigo Vivi
2017-05-26 23:23 ` [PATCH 2/3] drm/i915/glk: WA#0893: Also apply memory bw wa to Geminilake Rodrigo Vivi
2017-05-29 8:26 ` Ander Conselvan De Oliveira [this message]
2017-05-30 15:38 ` Vivi, Rodrigo
2017-05-26 23:23 ` [PATCH 3/3] RFC drm/i915: Don't increase the BW when WA is not required Rodrigo Vivi
2017-05-31 6:18 ` Mahesh Kumar
2017-05-29 6:27 ` [PATCH 1/3] drm/i915: Wa#0893 is defined per platform Mahesh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496046365.6086.4.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox