From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [RFC i-g-t] GEM features into feat_profile.json
Date: Wed, 31 May 2017 16:45:16 +0300 [thread overview]
Message-ID: <1496238316.15261.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170531125841.GR23936@nuc-i3427.alporthouse.com>
On ke, 2017-05-31 at 13:58 +0100, Chris Wilson wrote:
> On Wed, May 31, 2017 at 03:23:12PM +0300, Joonas Lahtinen wrote:
> >
> > Hello,
> >
> > I went through the gem_* tests from intel-gpu-tools and categorized
> > them into roughly categories "X | X robustness | X performance" ready
> > to be added to the feat_profile.json.
> >
> > Lets open a discussion which ones should go where. I tried to place a
> > single test to under only one category and I'm kind of hopeful that
> > we'll have the ability to add "depends_on" to create super features in
> > the future, instead of placing a single test under multiple categories.
> >
> > I didn't check all the subtests nor wildcard matching with other tests,
> > this is just all the test names placed under some categories.
>
> You seem to have assigned them exclusively to one category or another,
> most tests belong to a few of these categories. More when you consider a
> subtest may be targetting a completely different aspect.
Yes, that's what I meant to say :) Subtests should probably be matched
by another pattern like "\btiled\b", "\bflink\b" etc.
Ultimately there would be a resolver which would re-assign the
subtests:
"Global objects" would then get:
"include_subtests": "flink",
Which would steal subtests with /\bflink\b/ from tests. Do we agree
that one subtest would be assigned to one category only, or do you
want to see duplication even at that level?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-31 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 12:23 [RFC i-g-t] GEM features into feat_profile.json Joonas Lahtinen
2017-05-31 12:58 ` Chris Wilson
2017-05-31 13:45 ` Joonas Lahtinen [this message]
2017-05-31 14:02 ` Chris Wilson
2017-06-01 6:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496238316.15261.3.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox