Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Allow kswapd to pause the device whilst reaping
Date: Fri, 02 Jun 2017 13:24:43 +0300	[thread overview]
Message-ID: <1496399083.3795.2.camel@linux.intel.com> (raw)
In-Reply-To: <20170601133331.5973-1-chris@chris-wilson.co.uk>

On to, 2017-06-01 at 14:33 +0100, Chris Wilson wrote:
> In commit 5763ff04dc4e ("drm/i915: Avoid GPU stalls from kswapd") we
> stopped direct reclaim and kswapd from triggering GPU/client stalls
> whilst running (by restricting the objects they could reap to be idle).
> 
> However with abusive GPU usage, it becomes quite easy to starve kswapd
> of memory and prevent it from making forward progress towards obtaining
> enough free memory (thus driving the system closer to swap exhaustion).
> Relax the previous restriction to allow kswapd (but not direct reclaim)
> to stall the device whilst reaping purgeable pages.
> 
> v2: Also acquire the rpm wakelock to allow kswapd to unbind buffers.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

These are the kind of patches one wishes we had good testing coverage.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-06-02 10:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 13:33 [PATCH 1/3] drm/i915: Allow kswapd to pause the device whilst reaping Chris Wilson
2017-06-01 13:33 ` [PATCH 2/3] drm/i915: Encourage our shrinker more when our shmemfs allocations fails Chris Wilson
2017-06-01 13:33 ` [PATCH 3/3] drm/i915: Remove __GFP_NORETRY from our buffer allocator Chris Wilson
2017-06-02 10:28   ` Joonas Lahtinen
2017-06-05 10:35   ` [PATCH v2] " Chris Wilson
2017-06-05 10:47     ` Daniel Stone
2017-06-05 11:51       ` Chris Wilson
2017-06-05 12:26     ` Michal Hocko
2017-06-05 12:49       ` Chris Wilson
2017-06-05 13:08         ` Michal Hocko
2017-06-05 13:39           ` Chris Wilson
2017-06-06  9:04             ` Michal Hocko
2017-06-05 15:04           ` Chris Wilson
2017-06-06  9:08             ` Michal Hocko
2017-06-08 12:26     ` Michal Hocko
2017-06-08 16:04       ` Chris Wilson
2017-06-01 14:23 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Allow kswapd to pause the device whilst reaping Patchwork
2017-06-02 10:24 ` Joonas Lahtinen [this message]
2017-06-02 12:02 ` [PATCH 1/3] " Mika Kuoppala
2017-06-02 12:20   ` Chris Wilson
2017-06-02 12:38     ` Mika Kuoppala
2017-06-02 13:58       ` Chris Wilson
2017-06-05 11:10 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Allow kswapd to pause the device whilst reaping (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496399083.3795.2.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox