Re: [PATCH 3/5] drm/i915/cfl: Basic DDI plumbing for Coffee Lake.

["Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>]

On Wed, 2017-06-07 at 21:53 +0000, Vivi, Rodrigo wrote:
> On Wed, 2017-06-07 at 18:04 +0000, Pandiyan, Dhinakaran wrote:
> > On Tue, 2017-06-06 at 12:20 -0700, Rodrigo Vivi wrote:
> > > All here is pretty much like Kabylake.
> > > 
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > > index 8bac628..5b5bee6 100644
> > > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > > @@ -429,7 +429,7 @@ enum port intel_ddi_get_encoder_port(struct intel_encoder *encoder)
> > >  		}
> > >  	}
> > >  
> > 
> > I don't see the corresponding change in the caller
> > intel_ddi_get_buf_trans_edp(). 
> > 
^How about this?

intel_ddi_get_buf_trans_edp(struct drm_i915_private *dev_priv,
                            int *n_entries)
{
        if (IS_KABYLAKE(dev_priv) || IS_SKYLAKE(dev_priv)) {
                return skl_get_buf_trans_edp(dev_priv, n_entries);


> > 
> > > -	if (IS_KABYLAKE(dev_priv))
> > > +	if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))
> > >  		return kbl_get_buf_trans_dp(dev_priv, n_entries);
> > >  	else
> > >  		return skl_get_buf_trans_dp(dev_priv, n_entries);
> > > @@ -485,7 +485,7 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
> > >  intel_ddi_get_buf_trans_dp(struct drm_i915_private *dev_priv,
> > >  			   int *n_entries)
> > >  {
> > > -	if (IS_KABYLAKE(dev_priv)) {
> > > +	if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv)) {
> > 
> > What SKU's are being supported here? Anusha's sent patches for U, H and
> > S. I see distinct ddi_translation definitions for KBL U SKU's but I see
> > them missing for CFL in the callee kbl_get_buf_trans_dp. 
> 
> good catch! CFL-U is same as KBL-U and according to hardware engineers
> should start with same translation table. If something changes in the
> future we update here.
> 
> I will rebase and put this patch on top of PCI ID ones so I reuse the
> Anusha's definition to get CFL-U.
> 
> > 
> > 
> > -DK
> > 
> > 
> > >  		return kbl_get_buf_trans_dp(dev_priv, n_entries);
> > >  	} else if (IS_SKYLAKE(dev_priv)) {
> > >  		return skl_get_buf_trans_dp(dev_priv, n_entries);
> > > @@ -1478,7 +1478,7 @@ static void skl_ddi_set_iboost(struct intel_encoder *encoder, u32 level)
> > >  		if (dp_iboost) {
> > >  			iboost = dp_iboost;
> > >  		} else {
> > > -			if (IS_KABYLAKE(dev_priv))
> > > +			if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))
> > >  				ddi_translations = kbl_get_buf_trans_dp(dev_priv,
> > >  									&n_entries);
> > >  			else
> > 
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx