public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Lankhorst, Maarten" <maarten.lankhorst@intel.com>
To: "Shankar, Uma" <uma.shankar@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "Syrjala, Ville" <ville.syrjala@intel.com>
Subject: Re: [RFC v1 5/6] drm: Define helper to set legacy gamma table size
Date: Tue, 26 Sep 2017 10:15:06 +0000	[thread overview]
Message-ID: <1506420905.19693.10.camel@intel.com> (raw)
In-Reply-To: <E7C9878FBA1C6D42A1CA3F62AEB6945F7F002D3C@BGSMSX104.gar.corp.intel.com>

Shankar, Uma schreef op di 26-09-2017 om 15:41 [+0530]:
> > -----Original Message-----
> > From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On
> > Behalf Of
> > Lankhorst, Maarten
> > Sent: Tuesday, September 26, 2017 3:36 PM
> > To: Shankar, Uma <uma.shankar@intel.com>; intel-gfx@lists.freedeskt
> > op.org;
> > dri-devel@lists.freedesktop.org
> > Cc: Syrjala, Ville <ville.syrjala@intel.com>
> > Subject: Re: [RFC v1 5/6] drm: Define helper to set legacy gamma
> > table size
> > 
> > Hey,
> > 
> > Uma Shankar schreef op di 26-09-2017 om 13:32 [+0530]:
> > > Define a helper function to set legacy gamma table size for
> > > planes.
> > > 
> > > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > > ---
> > >  drivers/gpu/drm/drm_color_mgmt.c |   41
> > > ++++++++++++++++++++++++++++++++++++++
> > >  include/drm/drm_color_mgmt.h     |    3 +++
> > >  include/drm/drm_plane.h          |    4 ++++
> > >  3 files changed, 48 insertions(+)
> > 
> > Is this needed? I'm not aware of legacy tables for planes.
> 
> I was not getting very concrete info on this. So kept it as per pipe
> gamma implementation.
> I will try to get some more info and drop this in case it's not
> required.
> 

It's not, legacy gamma would only be used in drm_mode_gamma_get_ioctl,
which if you look at it only works for a crtc. :)

~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-09-26 10:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  8:02 [RFC V1 0/6] Add Plane Color Properties Uma Shankar
2017-09-26  8:02 ` [RFC v1 1/6] drm: Add Plane Degamma properties Uma Shankar
2017-09-26  8:02 ` [RFC v1 2/6] drm: Add Plane CTM property Uma Shankar
2017-09-26  8:02 ` [RFC v1 3/6] drm: Add Plane Gamma properties Uma Shankar
2017-09-26  8:02 ` [RFC v1 4/6] drm: Define helper function for plane color enabling Uma Shankar
2017-09-26  8:02 ` [RFC v1 5/6] drm: Define helper to set legacy gamma table size Uma Shankar
2017-09-26 10:05   ` Lankhorst, Maarten
2017-09-26 10:11     ` Shankar, Uma
2017-09-26 10:15       ` Lankhorst, Maarten [this message]
2017-09-26 10:20         ` Shankar, Uma
2017-09-26  8:02 ` [RFC v1 6/6] drm/i915: Enable plane color features Uma Shankar
2017-09-26  9:31 ` ✓ Fi.CI.BAT: success for Add Plane Color Properties Patchwork
2017-09-26 11:16 ` [Intel-gfx] [RFC V1 0/6] " Daniel Vetter
2017-09-26 12:53 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506420905.19693.10.camel@intel.com \
    --to=maarten.lankhorst@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox