From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt v3] igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch
Date: Mon, 04 Dec 2017 16:20:12 +0200 [thread overview]
Message-ID: <1512397212.4394.44.camel@linux.intel.com> (raw)
In-Reply-To: <20171202084717.29944-1-chris@chris-wilson.co.uk>
On Sat, 2017-12-02 at 08:47 +0000, Chris Wilson wrote:
> In CI, we were observing situations where the busy blt would complete
> before the very next instruction (in userspace) to assert that it was
> busy. This is entirely possible if the process was scheduled away and
> slept for longer than the arbitrary batch. Instead replace arbitrariness
> with a precise infinity.
>
> v2: Be respectful to UP!
> v3: Move spinbatch to owning process to avoid serialisation delays.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103829
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Even the variable names were good.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-04 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 22:43 [PATCH igt] igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch Chris Wilson
2017-12-01 23:03 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-12-01 23:29 ` [PATCH igt v2] " Chris Wilson
2017-12-02 0:22 ` ✓ Fi.CI.BAT: success for igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch (rev2) Patchwork
2017-12-02 1:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-12-02 8:47 ` [PATCH igt v3] igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch Chris Wilson
2017-12-04 14:20 ` Joonas Lahtinen [this message]
2017-12-02 9:13 ` ✓ Fi.CI.BAT: success for igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch (rev3) Patchwork
2017-12-02 10:00 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512397212.4394.44.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox