From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"tiwai@suse.de" <tiwai@suse.de>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/lpe: Remove double-encapsulation of info string
Date: Thu, 14 Dec 2017 22:03:49 +0000 [thread overview]
Message-ID: <1513290319.9641.25.camel@dk-H97M-D3H> (raw)
In-Reply-To: <20171213182858.2159-1-chris@chris-wilson.co.uk>
On Wed, 2017-12-13 at 18:28 +0000, Chris Wilson wrote:
> Just printk the string, or at least do not double up on the newlines!
>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Fixes: eef57324d926 ("drm/i915: setup bridge for HDMI LPE audio driver")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Jerome Anand <jerome.anand@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> ---
> drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
> index 3bf65288ffff..5809b29044fc 100644
> --- a/drivers/gpu/drm/i915/intel_lpe_audio.c
> +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
> @@ -193,7 +193,7 @@ static bool lpe_audio_detect(struct drm_i915_private *dev_priv)
> };
>
> if (!pci_dev_present(atom_hdaudio_ids)) {
> - DRM_INFO("%s\n", "HDaudio controller not detected, using LPE audio instead\n");
> + DRM_INFO("HDaudio controller not detected, using LPE audio instead\n");
> lpe_present = true;
> }
> }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-14 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 18:28 [PATCH] drm/i915/lpe: Remove double-encapsulation of info string Chris Wilson
2017-12-13 18:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-13 20:15 ` ✓ Fi.CI.IGT: " Patchwork
2017-12-14 22:03 ` Pandiyan, Dhinakaran [this message]
2017-12-15 14:03 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513290319.9641.25.camel@dk-H97M-D3H \
--to=dhinakaran.pandiyan@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox