Re: [PATCH i-g-t v3 7/8] tests/kms_plane_scaling: test scaler with clipping clamping, v3.

[Mika Kahola <mika.kahola@intel.com>]

On Mon, 2018-01-15 at 15:28 +0100, Maarten Lankhorst wrote:
> From: Jyoti Yadav <jyoti.r.yadav@intel.com>
> 
> This patch adds subtest to test scaler clipping and clamping
> scenario.
> 
> Changes since v1:
> - Modify test to work with the changes to kms_plane_scaling.
> (Maarten)
> Changes since v2:
> - Use get_num_scalers() to skip when needed.
> 

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_plane_scaling.c | 43
> +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index f514459584d1..36a6a8ef042b 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -416,6 +416,46 @@ test_plane_scaling_on_pipe(data_t *d, enum pipe
> pipe, igt_output_t *output)
>  	}
>  }
>  
> +static void
> +test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe
> pipe, igt_output_t *output)
> +{
> +	drmModeModeInfo *mode;
> +
> +	igt_require(get_num_scalers(d->devid, pipe) >= 2);
> +
> +	mode = igt_output_get_mode(output);
> +	d->plane1 = &d->display.pipes[pipe].planes[0];
> +	prepare_crtc(d, output, pipe, d->plane1, mode);
> +
> +	igt_create_pattern_fb(d->drm_fd,
> +			      mode->hdisplay, mode->vdisplay,
> +			      DRM_FORMAT_XRGB8888,
> +			      LOCAL_I915_FORMAT_MOD_X_TILED, &d-
> >fb[1]);
> +
> +	igt_create_pattern_fb(d->drm_fd,
> +			      mode->hdisplay, mode->vdisplay,
> +			      DRM_FORMAT_XRGB8888,
> +			      LOCAL_I915_FORMAT_MOD_Y_TILED, &d-
> >fb[2]);
> +
> +	igt_plane_set_fb(d->plane1, &d->fb[1]);
> +	d->plane2 = igt_output_get_plane(output, 1);
> +	igt_plane_set_fb(d->plane2, &d->fb[2]);
> +
> +	igt_fb_set_position(&d->fb[1], d->plane1, 0, 0);
> +	igt_fb_set_size(&d->fb[1], d->plane1, 300, 300);
> +	igt_plane_set_position(d->plane1, 100, 400);
> +	igt_fb_set_position(&d->fb[2], d->plane2, 0, 0);
> +	igt_fb_set_size(&d->fb[2], d->plane2, 400, 400);
> +	igt_plane_set_position(d->plane2, 100, 100);
> +
> +	/* scaled window size is outside the modeset area.*/
> +	igt_plane_set_size(d->plane1, mode->hdisplay + 200,
> +					    mode->vdisplay + 200);
> +	igt_plane_set_size(d->plane2, mode->hdisplay + 100,
> +					    mode->vdisplay + 100);
> +	igt_display_commit2(&d->display, COMMIT_ATOMIC);
> +}
> +
>  igt_main
>  {
>  	data_t data = {};
> @@ -452,6 +492,9 @@ igt_main
>  			for_each_valid_output_on_pipe(&data.display,
> pipe, output)
>  				test_scaler_with_rotation_pipe(&data
> , pipe, output);
>  
> +		igt_subtest_f("pipe-%s-scaler-with-clipping-
> clamping", kmstest_pipe_name(pipe))
> +			for_each_valid_output_on_pipe(&data.display,
> pipe, output)
> +				test_scaler_with_clipping_clamping_s
> cenario(&data, pipe, output);
>  	}
>  
>  	igt_fixture
-- 
Mika Kahola - Intel OTC

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx