From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "maarten.lankhorst@linux.intel.com" <maarten.lankhorst@linux.intel.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 4/5] drm/i915: Introduce a non-blocking power domain for vblank interrupts
Date: Tue, 16 Jan 2018 19:56:35 +0000 [thread overview]
Message-ID: <1516133940.30854.4.camel@dk-H97M-D3H> (raw)
In-Reply-To: <bc2de8fe-e26b-5707-24ed-007d78336d25@linux.intel.com>
On Tue, 2018-01-09 at 10:38 +0100, Maarten Lankhorst wrote:
> Op 08-01-18 om 20:59 schreef Pandiyan, Dhinakaran:
> > On Thu, 2018-01-04 at 18:08 -0800, Rodrigo Vivi wrote:
<snip>
> >> I will probably have more comments later, but just doing a brain dump now
> >> since I end up forgetting to write yesterday...
> >>
> >> The approach here in general is good and much better than that pre,post hooks.
> >> But I just believe we can do this here in a more generic approach than deviating
> >> the initial power well and domains.
> > I would have liked a generic approach (for display_power_{get,put}), but
> > I think this case is special enough that making it stand out is better.
> Agreed, I can think of no other way myself without making the generic case too complicated. The whole runtime power management became way too complex for a special case.
>
I found out that DMC keeps the hardware out of DC5/6 when vblank
interrupts are enabled. This simplified the solution a lot
(https://patchwork.freedesktop.org/series/36435/) Thanks for your review
on this series, would appreciate any feedback on the new one too :)
-DK
> ~Maarten
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-16 19:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 20:39 [PATCH 1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled Dhinakaran Pandiyan
2018-01-03 20:39 ` [PATCH 2/5] drm/vblank: Restoring vblank counts after device runtime PM events Dhinakaran Pandiyan
2018-01-03 20:55 ` Chris Wilson
2018-01-03 20:39 ` [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states Dhinakaran Pandiyan
2018-01-03 20:57 ` Chris Wilson
2018-01-04 21:25 ` Pandiyan, Dhinakaran
2018-01-04 11:35 ` Maarten Lankhorst
2018-01-04 21:51 ` Pandiyan, Dhinakaran
2018-01-05 11:23 ` Maarten Lankhorst
2018-01-05 18:09 ` Rodrigo Vivi
2018-01-05 18:45 ` Pandiyan, Dhinakaran
2018-01-06 9:51 ` Dhinakaran Pandiyan
2018-01-08 14:43 ` Maarten Lankhorst
2018-01-08 19:29 ` Pandiyan, Dhinakaran
2018-01-03 20:40 ` [PATCH 4/5] drm/i915: Introduce a non-blocking power domain for vblank interrupts Dhinakaran Pandiyan
2018-01-05 2:08 ` Rodrigo Vivi
2018-01-08 19:59 ` Pandiyan, Dhinakaran
2018-01-09 9:38 ` Maarten Lankhorst
2018-01-16 19:56 ` Pandiyan, Dhinakaran [this message]
2018-01-03 20:40 ` [PATCH 5/5] drm/i915: Use the vblank power domain disallow or disable DC states Dhinakaran Pandiyan
2018-01-03 20:53 ` [PATCH 1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled Chris Wilson
2018-01-03 21:01 ` ✓ Fi.CI.BAT: success for series starting with [1/5] " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-12-06 22:47 [PATCH 1/5] " Dhinakaran Pandiyan
2017-12-06 22:47 ` [PATCH 4/5] drm/i915: Introduce a non-blocking power domain for vblank interrupts Dhinakaran Pandiyan
2017-12-06 23:54 ` Rodrigo Vivi
2017-12-07 19:01 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516133940.30854.4.camel@dk-H97M-D3H \
--to=dhinakaran.pandiyan@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox