From: abhijeet.kumar@intel.com
To: tiwai@suse.de, abhijeet.kumar@intel.com, intel-gfx@lists.freedesktop.org
Subject: [PATCH] ALSA: hda: Remove finite loop from snd_hdac_sync_power_state()
Date: Tue, 13 Feb 2018 14:39:48 +0530 [thread overview]
Message-ID: <1518512988-24305-1-git-send-email-abhijeet.kumar@intel.com> (raw)
From: Abhijeet Kumar <abhijeet.kumar@intel.com>
Finite loop was causing few igt@pm_rpm tests failure for HSW and BDW.
Thus changing it back to infinite one.
References: https://bugs.freedesktop.org/show_bug.cgi?id=105069
Signed-off-by: Abhijeet Kumar <abhijeet.kumar@intel.com>
---
sound/hda/hdac_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c
index 7ba100bb1c3f..5a1dd570cea7 100644
--- a/sound/hda/hdac_device.c
+++ b/sound/hda/hdac_device.c
@@ -1079,9 +1079,9 @@ unsigned int snd_hdac_sync_power_state(struct hdac_device *codec,
hda_nid_t nid, unsigned int power_state)
{
unsigned long end_time = jiffies + msecs_to_jiffies(500);
- unsigned int state, actual_state, count;
+ unsigned int state, actual_state;
- for (count = 0; count < 500; count++) {
+ for (; ;) {
state = snd_hdac_codec_read(codec, nid, 0,
AC_VERB_GET_POWER_STATE, 0);
if (state & AC_PWRST_ERROR) {
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2018-02-13 9:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:09 abhijeet.kumar [this message]
2018-02-13 9:14 ` [PATCH] ALSA: hda: Remove finite loop from snd_hdac_sync_power_state() Takashi Iwai
2018-02-13 9:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-13 9:45 ` Chris Wilson
2018-02-13 10:12 ` Kumar, Abhijeet
2018-02-13 10:36 ` Saarinen, Jani
2018-02-13 10:24 ` [PATCH v2] " abhijeet.kumar
2018-02-13 12:41 ` Kumar, Abhijeet
2018-02-13 12:47 ` Chris Wilson
2018-02-13 13:11 ` Kumar, Abhijeet
2018-02-13 13:29 ` Takashi Iwai
2018-02-13 13:51 ` Kumar, Abhijeet
2018-02-13 12:50 ` Jani Nikula
2018-02-13 11:02 ` ✓ Fi.CI.BAT: success for ALSA: hda: Remove finite loop from snd_hdac_sync_power_state() (rev2) Patchwork
2018-02-13 14:14 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518512988-24305-1-git-send-email-abhijeet.kumar@intel.com \
--to=abhijeet.kumar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox