From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/7] drm/arc: Stop consulting plane->fb
Date: Fri, 6 Apr 2018 08:50:37 +0000 [thread overview]
Message-ID: <1523004636.18601.0.camel@synopsys.com> (raw)
In-Reply-To: <20180405195035.24722-1-ville.syrjala@linux.intel.com>
Hi Ville,
On Thu, 2018-04-05 at 22:50 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We want to stop using plane->fb with atomic driver, so stop looking at
> it.
>
> I have no idea what this code is trying to achieve. There is no
> corresponding check in the enable path. Also since
> arc_pgu_set_pxl_fmt() will anyway oops if there is no fb I'm going
> to assuming that I can just remove the check entirely. There seems
> to be a general shortage of .atomic_check() in this driver...
>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Alexey Brodkin <abrodkin@synopys.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-04-06 9:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 19:50 [PATCH 1/7] drm/arc: Stop consulting plane->fb Ville Syrjala
2018-04-05 19:50 ` [PATCH 2/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_atomic_check_modeset() Ville Syrjala
2018-04-05 20:15 ` Deepak Singh Rawat
2018-04-05 20:29 ` Ville Syrjälä
2018-04-05 20:38 ` Deepak Singh Rawat
2018-04-05 19:50 ` [PATCH 3/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_helper_dirty() Ville Syrjala
2018-04-05 20:15 ` Thomas Hellstrom
2018-04-05 20:26 ` Ville Syrjälä
2018-04-05 20:33 ` [PATCH v2 " Ville Syrjala
2018-04-06 8:51 ` [PATCH " kbuild test robot
2018-04-05 19:50 ` [PATCH 4/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_update_implicit_fb() Ville Syrjala
2018-04-06 18:21 ` Deepak Singh Rawat
2018-04-05 19:50 ` [PATCH 5/7] drm/vmwgfx: Stop updating plane->fb Ville Syrjala
2018-04-06 19:14 ` Deepak Singh Rawat
2018-04-06 19:35 ` Ville Syrjälä
2018-05-11 15:54 ` Ville Syrjälä
2018-05-16 17:10 ` Deepak Singh Rawat
2018-04-05 19:50 ` [PATCH 6/7] drm/vmwgfx: Stop using plane->fb in atomic_enable() Ville Syrjala
2018-04-06 18:56 ` Deepak Singh Rawat
2018-04-05 19:50 ` [PATCH 7/7] drm/vmwgfx: Stop messing about with plane->fb/old_fb/crtc Ville Syrjala
2018-04-05 20:39 ` Daniel Vetter
2018-04-05 20:07 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/arc: Stop consulting plane->fb Patchwork
2018-04-05 20:08 ` [PATCH 1/7] " Daniel Vetter
2018-04-05 20:19 ` Ville Syrjälä
2018-04-05 20:43 ` Daniel Vetter
2018-04-05 20:23 ` ✓ Fi.CI.BAT: success for series starting with [1/7] " Patchwork
2018-04-05 20:51 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/arc: Stop consulting plane->fb (rev2) Patchwork
2018-04-05 21:06 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-05 22:14 ` ✓ Fi.CI.IGT: success for series starting with [1/7] drm/arc: Stop consulting plane->fb Patchwork
2018-04-05 22:50 ` ✗ Fi.CI.IGT: warning for series starting with [1/7] drm/arc: Stop consulting plane->fb (rev2) Patchwork
2018-04-06 5:58 ` Saarinen, Jani
2018-04-06 8:50 ` Alexey Brodkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523004636.18601.0.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox