From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: Mahesh Kumar <mahesh1.kumar@intel.com>, intel-gfx@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com
Subject: Re: [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw
Date: Mon, 04 Jun 2018 16:49:20 -0700 [thread overview]
Message-ID: <1528156160.2774.24.camel@intel.com> (raw)
In-Reply-To: <20180517132626.5885-1-mahesh1.kumar@intel.com>
Em Qui, 2018-05-17 às 18:56 +0530, Mahesh Kumar escreveu:
> Do not update number of enabled dbuf slices in dev_priv struct until
> we
> actually enable/disable dbuf slice in hw. This is leading to never
> updating dbuf slices and resulting in DBuf slice mismatch warning.
>
> Fixes: aa9664ffe863 ("drm/i915/icl: Enable 2nd DBuf slice only when
> needed")
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
I'll merge it.
> ---
> drivers/gpu/drm/i915/intel_pm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c
> index b85229e153c4..53aaaa3e6886 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5150,7 +5150,6 @@ skl_copy_ddb_for_pipe(struct skl_ddb_values
> *dst,
> sizeof(dst->ddb.uv_plane[pipe]));
> memcpy(dst->ddb.plane[pipe], src->ddb.plane[pipe],
> sizeof(dst->ddb.plane[pipe]));
> - dst->ddb.enabled_slices = src->ddb.enabled_slices;
> }
>
> static void
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-06-04 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:26 [PATCH] drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw Mahesh Kumar
2018-05-17 14:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-17 17:02 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-04 23:49 ` Paulo Zanoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528156160.2774.24.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mahesh1.kumar@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox