From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: ville.syrjala@intel.com, jonas@kwiboo.se, hansverk@cisco.com,
Uma Shankar <uma.shankar@intel.com>,
maarten.lankhorst@intel.com
Subject: [v4 2/3] drm: Add DP colorspace property
Date: Tue, 27 Nov 2018 22:10:42 +0530 [thread overview]
Message-ID: <1543336843-22193-3-git-send-email-uma.shankar@intel.com> (raw)
In-Reply-To: <1543336843-22193-1-git-send-email-uma.shankar@intel.com>
This patch adds a DP colorspace property, enabling
userspace to switch to various supported colorspaces.
This will help enable BT2020 along with other colorspaces.
v2: Addressed Maarten and Ville's review comments. Enhanced
the colorspace enum to incorporate both HDMI and DP supported
colorspaces. Also, added a default option for colorspace.
v3: Split the changes to have separate colorspace property for
DP and HDMI.
v4: Addressed Chris and Ville's review comments, and created a
common colorspace property for DP and HDMI, filtered the list
based on the colorspaces supported by the respective protocol
standard.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/drm_connector.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 57d36e4..30e2e6f 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -850,6 +850,29 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info,
{ COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" },
};
+static const struct drm_prop_enum_list dp_colorspace[] = {
+ /* For Default case, driver will set the colorspace */
+ { COLORIMETRY_DEFAULT, "Default" },
+ /* Standard Definition Colorimetry based on CEA 861 */
+ { COLORIMETRY_ITU_601, "ITU_601" },
+ { COLORIMETRY_ITU_709, "ITU_709" },
+ /* Standard Definition Colorimetry based on IEC 61966-2-4 */
+ { COLORIMETRY_XV_YCC_601, "XV_YCC_601" },
+ /* High Definition Colorimetry based on IEC 61966-2-4 */
+ { COLORIMETRY_XV_YCC_709, "XV_YCC_709" },
+ /* Colorimetry based on IEC 61966-2-5 */
+ { COLORIMETRY_OPRGB, "opRGB" },
+ /* DP MSA Colorimetry */
+ { DP_COLORIMETRY_Y_CBCR_ITU_601, "YCBCR_ITU_601" },
+ { DP_COLORIMETRY_Y_CBCR_ITU_709, "YCBCR_ITU_709" },
+ { DP_COLORIMETRY_SRGB, "sRGB" },
+ { DP_COLORIMETRY_RGB_WIDE_GAMUT, "RGB Wide Gamut" },
+ { DP_COLORIMETRY_SCRGB, "scRGB" },
+ { DP_COLORIMETRY_DCI_P3, "DCI-P3" },
+ { DP_COLORIMETRY_CUSTOM_COLOR_PROFILE, "Custom Profile" },
+};
+
+
/**
* DOC: standard connector properties
*
@@ -1454,6 +1477,14 @@ int drm_mode_create_colorspace_property(struct drm_connector *connector)
ARRAY_SIZE(hdmi_colorspace));
if (!prop)
return -ENOMEM;
+ } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
+ connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+
+ prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+ "Colorspace", dp_colorspace,
+ ARRAY_SIZE(dp_colorspace));
+ if (!prop)
+ return -ENOMEM;
}
connector->colorspace_property = prop;
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-11-27 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:40 [v4 0/3] Add Colorspace connector property interface Uma Shankar
2018-11-27 16:40 ` [v4 1/3] drm: Add HDMI colorspace property Uma Shankar
2018-11-28 1:01 ` kbuild test robot
2018-11-28 16:11 ` Sharma, Shashank
2018-11-29 14:44 ` Shankar, Uma
2018-11-27 16:40 ` Uma Shankar [this message]
2018-11-28 11:41 ` [v4 2/3] drm: Add DP " Brian Starkey
2018-11-28 13:59 ` Shankar, Uma
2018-11-28 16:13 ` Sharma, Shashank
2018-11-27 16:40 ` [v4 3/3] drm/i915: Attach colorspace property and enable modeset Uma Shankar
2018-11-28 20:49 ` kbuild test robot
2018-11-27 16:42 ` ✗ Fi.CI.CHECKPATCH: warning for Add Colorspace connector property interface (rev4) Patchwork
2018-11-27 16:45 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-27 17:05 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-27 20:58 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-28 11:56 ` [v4 0/3] Add Colorspace connector property interface Brian Starkey
2018-11-28 14:29 ` Shankar, Uma
2018-11-28 14:47 ` Brian Starkey
2018-11-29 14:40 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543336843-22193-3-git-send-email-uma.shankar@intel.com \
--to=uma.shankar@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hansverk@cisco.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonas@kwiboo.se \
--cc=maarten.lankhorst@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox