From: Swati Sharma <swati2.sharma@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, daniel.vetter@ffwll.ch,
ankit.k.nautiyal@intel.com
Subject: [v5][PATCH 08/11] drm/i915: Extract bdw_read_luts()
Date: Sat, 4 May 2019 22:41:37 +0530 [thread overview]
Message-ID: <1556989900-21972-9-git-send-email-swati2.sharma@intel.com> (raw)
In-Reply-To: <1556989900-21972-1-git-send-email-swati2.sharma@intel.com>
In this patch, gamma and degamma hw blobs are created for BDW.
v4: -No need to initialize *blob [Jani]
-Removed right shifts [Jani]
-Dropped dev local var [Jani]
v5: -Returned blob instead of assigning it internally within the
function [Ville]
-Renamed bdw_get_color_config() to bdw_read_luts() [Ville]
-Enabled degamma lut validation [Ville]
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/gpu/drm/i915/intel_color.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
index 32cea6d..c5cc1d9 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++ b/drivers/gpu/drm/i915/intel_color.c
@@ -1533,6 +1533,19 @@ static void glk_read_luts(struct intel_crtc_state *crtc_state)
crtc_state->base.gamma_lut = bdw_read_lut_10(crtc_state, PAL_PREC_INDEX_VALUE(0));
}
+static void bdw_read_luts(struct intel_crtc_state *crtc_state)
+{
+ if (crtc_state->gamma_mode == GAMMA_MODE_MODE_8BIT) {
+ crtc_state->base.gamma_lut = i9xx_read_lut_8(crtc_state);
+ } else if (crtc_state->gamma_mode == GAMMA_MODE_MODE_SPLIT) {
+ crtc_state->base.degamma_lut = bdw_read_lut_10(crtc_state, PAL_PREC_SPLIT_MODE | PAL_PREC_INDEX_VALUE(0));
+ crtc_state->base.gamma_lut = bdw_read_lut_10(crtc_state, PAL_PREC_INDEX_VALUE(512));
+ } else {
+ crtc_state->base.degamma_lut = bdw_read_lut_10(crtc_state, PAL_PREC_INDEX_VALUE(0));
+ crtc_state->base.gamma_lut = bdw_read_lut_10(crtc_state, PAL_PREC_INDEX_VALUE(0));
+ }
+}
+
void intel_color_init(struct intel_crtc *crtc)
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
@@ -1580,9 +1593,10 @@ void intel_color_init(struct intel_crtc *crtc)
} else if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv)) {
dev_priv->display.load_luts = glk_load_luts;
dev_priv->display.read_luts = glk_read_luts;
- }
- else if (INTEL_GEN(dev_priv) >= 8)
+ } else if (INTEL_GEN(dev_priv) >= 8) {
dev_priv->display.load_luts = bdw_load_luts;
+ dev_priv->display.read_luts = bdw_read_luts;
+ }
else if (INTEL_GEN(dev_priv) >= 7)
dev_priv->display.load_luts = ivb_load_luts;
else
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-04 17:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 17:11 [PATCH 00/11] drm/i915: adding state checker for gamma lut values Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 01/11] drm/i915: Introduce vfunc read_luts() to create hw lut Swati Sharma
2019-05-06 13:21 ` Jani Nikula
2019-05-06 13:29 ` Ville Syrjälä
2019-05-06 13:41 ` Jani Nikula
2019-05-06 14:24 ` Sharma, Swati2
2019-05-07 6:48 ` Jani Nikula
2019-05-07 7:08 ` Jani Nikula
2019-05-04 17:11 ` [v5][PATCH 02/11] drm/i915: Enable intel_color_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 03/11] drm/i915: Extract i9xx_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 04/11] drm/i915: Extract chv_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 05/11] drm/i915: Extract i965_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 06/11] drm/i915: Extract icl_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 07/11] drm/i915: Extract glk_read_luts() Swati Sharma
2019-05-04 17:11 ` Swati Sharma [this message]
2019-05-04 17:11 ` [v5][PATCH 09/11] drm/i915: Extract ivb_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 10/11] drm/i915: Extract ilk_read_luts() Swati Sharma
2019-05-04 17:11 ` [v5][PATCH 11/11] drm/i915: Add intel_color_lut_equal() to compare hw and sw gamma/degamma lut values Swati Sharma
2019-05-06 18:33 ` Ville Syrjälä
2019-05-06 18:57 ` Sharma, Swati2
2019-05-07 10:53 ` Ville Syrjälä
2019-05-04 17:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev7) Patchwork
2019-05-04 17:31 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-04 17:40 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556989900-21972-9-git-send-email-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox