From: Lee Shawn C <shawn.c.lee@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
Cooper Chiou <cooper.chiou@intel.com>
Subject: [PATCH v2] drm/i915: Refine eDP aux backlight enable/disable sequence
Date: Tue, 25 Jun 2019 08:35:10 -0700 [thread overview]
Message-ID: <1561476910-23655-1-git-send-email-shawn.c.lee@intel.com> (raw)
In-Reply-To: <1561087486-19339-1-git-send-email-shawn.c.lee@intel.com>
Modify aux backlight enable/disable sequence just like what we
did for genernal eDP panel. Setup PWM freq and brightness level
before enable display backlight.
v2: According to spec, it is not necessary to set PWM to 0 if
backlight enable already off. Remove intel_dp_aux_set_backlight to 0.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 6b0b73479fb8..70d9b9c9586f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -216,8 +216,8 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st
}
}
- set_aux_backlight_enable(intel_dp, true);
intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level);
+ set_aux_backlight_enable(intel_dp, true);
}
static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-25 15:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 3:24 [PATCH] drm/i915: Refine eDP aux backlight enable/disable sequence Lee Shawn C
2019-06-21 3:36 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-21 10:52 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-25 14:11 ` [PATCH] " Jani Nikula
2019-06-25 14:49 ` Lee, Shawn C
2019-06-25 15:12 ` Jani Nikula
2019-06-25 15:35 ` Lee Shawn C [this message]
2019-06-25 15:13 ` [PATCH v2] " Jani Nikula
2019-06-25 15:29 ` Lee, Shawn C
2019-06-25 16:12 ` ✗ Fi.CI.BAT: failure for drm/i915: Refine eDP aux backlight enable/disable sequence (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-06-14 6:09 [PATCH 1/2] drm/i915: Refine eDP aux backlight enable/disable sequence Lee, Shawn C
2019-06-21 3:02 ` [PATCH v2] " Lee Shawn C
2019-06-21 2:53 ` Lee, Shawn C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561476910-23655-1-git-send-email-shawn.c.lee@intel.com \
--to=shawn.c.lee@intel.com \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox