Re: [PATCH 01/10] drm/i915: Use variable for debugfs device status

[Stuart Summers <stuart.summers@intel.com>]

On Fri, 2019-08-02 at 22:24 +0100, Chris Wilson wrote:
> Quoting Stuart Summers (2019-08-02 21:51:25)
> > Use a local variable to find SSEU runtime information
> > in various debugfs functions.
> > 
> > Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> > ---
> > @@ -3969,10 +3969,10 @@ static void
> > broadwell_sseu_device_status(struct drm_i915_private *dev_priv,
> >  
> >         if (sseu->slice_mask) {
> >                 sseu->eu_per_subslice =
> > -                       RUNTIME_INFO(dev_priv)-
> > >sseu.eu_per_subslice;
> > +                       info->sseu.eu_per_subslice;
> >                 for (s = 0; s < fls(sseu->slice_mask); s++) {
> >                         sseu->subslice_mask[s] =
> > -                               RUNTIME_INFO(dev_priv)-
> > >sseu.subslice_mask[s];
> > +                               info->sseu.subslice_mask[s];
> >                 }
> >                 sseu->eu_total = sseu->eu_per_subslice *
> >                                  intel_sseu_subslice_total(sseu);
> > @@ -3980,7 +3980,7 @@ static void
> > broadwell_sseu_device_status(struct drm_i915_private *dev_priv,
> >                 /* subtract fused off EU(s) from enabled slice(s)
> > */
> >                 for (s = 0; s < fls(sseu->slice_mask); s++) {
> >                         u8 subslice_7eu =
> > -                               RUNTIME_INFO(dev_priv)-
> > >sseu.subslice_7eu[s];
> > +                               info->sseu.subslice_7eu[s];
> 
> These 3 condense back to single lines.

Thanks for the review! I'll reduce these to single lines in the next
revision.

Thanks,
Stuart

> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx