From: Clinton Taylor <Clinton.A.Taylor@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915: Assume combo PHY HBR3 will be inherited by future platforms
Date: Thu, 6 Jun 2019 15:04:16 -0700 [thread overview]
Message-ID: <158a1425-1a88-e9b3-e87f-a1440a6a9b9a@intel.com> (raw)
In-Reply-To: <20190606180942.13743-1-matthew.d.roper@intel.com>
Yes, this makes more sense.
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>
-Clint
On 6/6/19 11:09 AM, Matt Roper wrote:
> We shouldn't assume that HBR3 on combo PHYs is an EHL-specific
> capability. Let's follow the standard i915 convention of assuming
> future platforms will inherit all features of the latest platform.
>
> Fixes: b71438606343 ("drm/i915/ehl: Support HBR3 on EHL combo PHY")
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index b099a9dc28fd..4e2a06513e7d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -332,7 +332,7 @@ static int icl_max_source_rate(struct intel_dp *intel_dp)
> enum port port = dig_port->base.port;
>
> if (intel_port_is_combophy(dev_priv, port) &&
> - !IS_ELKHARTLAKE(dev_priv) &&
> + IS_ICELAKE(dev_priv) &&
> !intel_dp_is_edp(intel_dp))
> return 540000;
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-06 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 18:09 [PATCH] drm/i915: Assume combo PHY HBR3 will be inherited by future platforms Matt Roper
2019-06-06 18:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-06 22:04 ` Clinton Taylor [this message]
2019-06-09 2:56 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158a1425-1a88-e9b3-e87f-a1440a6a9b9a@intel.com \
--to=clinton.a.taylor@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox