From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
Date: Tue, 16 Oct 2018 16:03:38 -0700 [thread overview]
Message-ID: <15e9b86c-3f53-668e-8a7d-2ad183e05ae8@intel.com> (raw)
In-Reply-To: <20181016085931.23532-1-michal.wajdeczko@intel.com>
On 16/10/18 01:59, Michal Wajdeczko wrote:
> In commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading") we
> stopped converting errors detected during firmware transfer into
> -EAGAIN and this indirectly killed our workarounds for Gen9 GuC.
> Reactivate those workarounds by looking for actual -ETIMEDOUT error.
>
> Testcase: igt@drv_selftest@live_hangcheck
> Reported-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> References: commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading")
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_uc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index b1b3e81..b34c318 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -376,7 +376,7 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
>
> intel_guc_init_params(guc);
> ret = intel_guc_fw_upload(guc);
> - if (ret == 0 || ret != -EAGAIN)
> + if (ret == 0 || ret != -ETIMEDOUT)
> break;
>
> DRM_DEBUG_DRIVER("GuC fw load failed: %d; will reset and "
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-16 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 8:59 [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Michal Wajdeczko
2018-10-16 8:59 ` [PATCH 2/2] HAX enable GuC for CI Michal Wajdeczko
2018-10-16 9:41 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Patchwork
2018-10-16 10:05 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-16 23:03 ` Daniele Ceraolo Spurio [this message]
2018-10-17 8:09 ` [PATCH 1/2] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e9b86c-3f53-668e-8a7d-2ad183e05ae8@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox