From: Vidya Srinivas <vidya.srinivas@intel.com>
To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Cc: markyacoub@chromium.org, charlton.lin@intel.com
Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/drm_read: Fix subtest invalid-buffer
Date: Fri, 28 May 2021 10:02:47 +0530 [thread overview]
Message-ID: <1622176367-12608-1-git-send-email-vidya.srinivas@intel.com> (raw)
Using (void *)-1 directly in read is aborting on chrome systems.
Following message is seen.
Starting subtest: invalid-buffer
*** buffer overflow detected ***: terminated
Received signal SIGABRT.
Stack trace:
Aborted (core dumped)
Patch just adds a pointer variable and uses it in read.
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/drm_read.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/drm_read.c b/tests/drm_read.c
index ccf9d822fd8d..2fdec5be4078 100644
--- a/tests/drm_read.c
+++ b/tests/drm_read.c
@@ -103,10 +103,11 @@ static void teardown(int fd)
static void test_invalid_buffer(int in)
{
int fd = setup(in, 0);
+ void *add = (void *)-1;
alarm(1);
- igt_assert_eq(read(fd, (void *)-1, 4096), -1);
+ igt_assert_eq(read(fd, add, 4096), -1);
igt_assert_eq(errno, EFAULT);
teardown(fd);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2021-05-28 4:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 4:32 Vidya Srinivas [this message]
2021-06-04 18:42 ` [Intel-gfx] [PATCH i-g-t] [RFC] tests/drm_read: Fix subtest invalid-buffer Mark Yacoub
2021-06-05 5:46 ` Srinivas, Vidya
2021-06-21 10:28 ` Petri Latvala
2021-06-21 12:12 ` Srinivas, Vidya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622176367-12608-1-git-send-email-vidya.srinivas@intel.com \
--to=vidya.srinivas@intel.com \
--cc=charlton.lin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=markyacoub@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox