From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Tidy up vfio_device life cycle (rev2)
Date: Wed, 31 Aug 2022 06:36:10 -0000 [thread overview]
Message-ID: <166192777092.4260.13461840022399509007@emeril.freedesktop.org> (raw)
In-Reply-To: <20220827171037.30297-1-kevin.tian@intel.com>
== Series Details ==
Series: Tidy up vfio_device life cycle (rev2)
URL : https://patchwork.freedesktop.org/series/107838/
State : warning
== Summary ==
Error: dim checkpatch failed
405257a130f0 vfio: Add helpers for unifying vfio_device life cycle
-:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#69: FILE: drivers/vfio/vfio_main.c:512:
+struct vfio_device *_vfio_alloc_device(size_t size, struct device *dev,
+ const struct vfio_device_ops *ops)
-:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_struct' - possible side-effects?
#189: FILE: include/linux/vfio.h:147:
+#define vfio_alloc_device(dev_struct, member, dev, ops) \
+ container_of(_vfio_alloc_device(sizeof(struct dev_struct) + \
+ BUILD_BUG_ON_ZERO(offsetof( \
+ struct dev_struct, member)), \
+ dev, ops), \
+ struct dev_struct, member)
-:189: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#189: FILE: include/linux/vfio.h:147:
+#define vfio_alloc_device(dev_struct, member, dev, ops) \
+ container_of(_vfio_alloc_device(sizeof(struct dev_struct) + \
+ BUILD_BUG_ON_ZERO(offsetof( \
+ struct dev_struct, member)), \
+ dev, ops), \
+ struct dev_struct, member)
total: 0 errors, 0 warnings, 3 checks, 147 lines checked
df0991d343cd vfio/pci: Use the new device life cycle helpers
43ddd4b3b4eb vfio/mlx5: Use the new device life cycle helpers
-:21: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#21: FILE: drivers/vfio/pci/mlx5/main.c:584:
+ struct mlx5vf_pci_core_device *mvdev = container_of(
-:33: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#33: FILE: drivers/vfio/pci/mlx5/main.c:596:
+
+}
-:37: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#37: FILE: drivers/vfio/pci/mlx5/main.c:600:
+ struct mlx5vf_pci_core_device *mvdev = container_of(
total: 0 errors, 0 warnings, 3 checks, 74 lines checked
e4bb5c47eaf7 vfio/hisi_acc: Use the new device life cycle helpers
f5c7d76e8b8f vfio/mdpy: Use the new device life cycle helpers
ac90d6a82ba1 vfio/mtty: Use the new device life cycle helpers
c3540147339d vfio/mbochs: Use the new device life cycle helpers
73067e42b2dd drm/i915/gvt: Use the new device life cycle helpers
-:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#155: FILE: drivers/gpu/drm/i915/gvt/vgpu.c:365:
+static int __intel_gvt_create_vgpu(struct intel_vgpu *vgpu,
struct intel_vgpu_creation_params *param)
total: 0 errors, 0 warnings, 1 checks, 197 lines checked
dd517d04b701 vfio/ap: Use the new device life cycle helpers
291765af61e2 vfio/fsl-mc: Use the new device life cycle helpers
910cf1cc7e4e vfio/platform: Use the new device life cycle helpers
1e4453d1c194 vfio/amba: Use the new device life cycle helpers
ce8562ac714a vfio/ccw: Use the new device life cycle helpers
45939f17c91c vfio: Rename vfio_device_put() and vfio_device_try_get()
212d729dc851 vfio: Add struct device to vfio_device
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15:
> > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the
-:48: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#48:
new file mode 100644
-:60: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 2 warnings, 0 checks, 8 lines checked
next prev parent reply other threads:[~2022-08-31 6:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 17:10 [Intel-gfx] [PATCH 00/15] Tidy up vfio_device life cycle Kevin Tian
2022-08-27 10:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-08-27 10:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-27 17:10 ` [Intel-gfx] [PATCH 01/15] vfio: Add helpers for unifying " Kevin Tian
2022-08-30 13:42 ` Anthony Krowiak
[not found] ` <Yw4oUL33TbJK6inc@ziepe.ca>
2022-08-30 19:43 ` Anthony Krowiak
2022-08-31 6:03 ` Tian, Kevin
2022-08-27 17:10 ` [Intel-gfx] [PATCH 02/15] vfio/pci: Use the new device life cycle helpers Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 03/15] vfio/mlx5: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 04/15] vfio/hisi_acc: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 05/15] vfio/mdpy: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 06/15] vfio/mtty: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 07/15] vfio/mbochs: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 08/15] drm/i915/gvt: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 09/15] vfio/ap: " Kevin Tian
2022-08-30 13:43 ` Anthony Krowiak
2022-08-27 17:10 ` [Intel-gfx] [PATCH 10/15] vfio/fsl-mc: " Kevin Tian
[not found] ` <Yw6pxrS1zb5JKt8q@ziepe.ca>
2022-08-31 6:14 ` Tian, Kevin
2022-08-27 17:10 ` [Intel-gfx] [PATCH 11/15] vfio/platform: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 12/15] vfio/amba: " Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 13/15] vfio/ccw: " Kevin Tian
2022-08-27 10:39 ` Tian, Kevin
2022-08-27 17:10 ` [Intel-gfx] [PATCH 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get() Kevin Tian
2022-08-27 17:10 ` [Intel-gfx] [PATCH 15/15] vfio: Add struct device to vfio_device Kevin Tian
2022-08-30 22:18 ` Alex Williamson
[not found] ` <Yw6i7btDKcUDPADP@ziepe.ca>
2022-08-31 6:10 ` Tian, Kevin
2022-08-31 17:15 ` Alex Williamson
2022-09-01 0:46 ` Tian, Kevin
2022-09-01 2:05 ` Alex Williamson
[not found] ` <Yw6sEghuAm6OAXWE@ziepe.ca>
2022-08-31 6:14 ` Tian, Kevin
2022-08-27 22:41 ` [Intel-gfx] [PATCH 00/15] Tidy up vfio_device life cycle Tian, Kevin
2022-08-30 18:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2022-08-31 0:34 ` [Intel-gfx] [PATCH 00/15] " Jason Gunthorpe
2022-08-31 6:14 ` Tian, Kevin
2022-08-31 6:36 ` Patchwork [this message]
2022-08-31 6:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Tidy up vfio_device life cycle (rev2) Patchwork
2022-08-31 6:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-31 16:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166192777092.4260.13461840022399509007@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox