Re: [Intel-gfx] [PATCH 1/7] drm/i915/mtl: Initial DDI port setup

["Govindapillai, Vinod" <vinod.govindapillai@intel.com>]

On Mon, 2023-03-27 at 15:34 +0300, Mika Kahola wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
> 
> Initialization sequences and C10 phy are in place to be able to enable
> the first 2 ports of MTL. The other ports use C20 phy that still need
> to be properly added. Enable the first ports for now, keeping a TODO
> comment about the others.
> 
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> ---

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

>  drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 5a386c7c0bc9..9fe6e33a66d6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7796,7 +7796,11 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>         if (!HAS_DISPLAY(dev_priv))
>                 return;
>  
> -       if (IS_DG2(dev_priv)) {
> +       if (IS_METEORLAKE(dev_priv)) {
> +               /* TODO: initialize TC ports as well */
> +               intel_ddi_init(dev_priv, PORT_A);
> +               intel_ddi_init(dev_priv, PORT_B);
> +       } else if (IS_DG2(dev_priv)) {
>                 intel_ddi_init(dev_priv, PORT_A);
>                 intel_ddi_init(dev_priv, PORT_B);
>                 intel_ddi_init(dev_priv, PORT_C);