From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: "Robert M. Fosha" <robert.m.fosha@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Update H2G enable logging action definition
Date: Fri, 27 Sep 2019 14:24:16 -0700 [thread overview]
Message-ID: <182d7b4a-c34f-33f5-e317-3c584d85c8f3@intel.com> (raw)
In-Reply-To: <20190927180426.23931-1-robert.m.fosha@intel.com>
On 9/27/19 11:04 AM, Robert M. Fosha wrote:
> GuC enable logging H2G action definition changed some time ago from 0xE000
> to 0x40. All current GuC FW blobs use this definition, so fix the action
> definition in driver to match.
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Robert M. Fosha <robert.m.fosha@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
We really need to add some proper testing for the guc log relay,
otherwise we'll only notice bugs in there (like this one) when we need
to use the relay for debug of other issues.
Daniele
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> index 1d3cdd67ca2f..a26a85d50209 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> @@ -548,6 +548,7 @@ enum intel_guc_action {
> INTEL_GUC_ACTION_ALLOCATE_DOORBELL = 0x10,
> INTEL_GUC_ACTION_DEALLOCATE_DOORBELL = 0x20,
> INTEL_GUC_ACTION_LOG_BUFFER_FILE_FLUSH_COMPLETE = 0x30,
> + INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING = 0x40,
> INTEL_GUC_ACTION_FORCE_LOG_BUFFER_FLUSH = 0x302,
> INTEL_GUC_ACTION_ENTER_S_STATE = 0x501,
> INTEL_GUC_ACTION_EXIT_S_STATE = 0x502,
> @@ -556,7 +557,6 @@ enum intel_guc_action {
> INTEL_GUC_ACTION_AUTHENTICATE_HUC = 0x4000,
> INTEL_GUC_ACTION_REGISTER_COMMAND_TRANSPORT_BUFFER = 0x4505,
> INTEL_GUC_ACTION_DEREGISTER_COMMAND_TRANSPORT_BUFFER = 0x4506,
> - INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING = 0x0E000,
> INTEL_GUC_ACTION_LIMIT
> };
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-09-27 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 18:04 [PATCH] drm/i915/guc: Update H2G enable logging action definition Robert M. Fosha
2019-09-27 19:19 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-09-27 21:24 ` Daniele Ceraolo Spurio [this message]
2019-09-28 10:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-09-30 20:16 ` Fosha, Robert M
2019-10-01 23:18 ` Fosha, Robert M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=182d7b4a-c34f-33f5-e317-3c584d85c8f3@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert.m.fosha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox