From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove obsolete engine clenaup
Date: Wed, 17 Jul 2019 14:28:30 +0100 [thread overview]
Message-ID: <1bcbef89-5e9b-e35f-869d-369e2689a33a@linux.intel.com> (raw)
In-Reply-To: <156336989630.4375.10279287150317637256@skylake-alporthouse-com>
On 17/07/2019 14:24, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-07-17 14:18:56)
>>
>> On 17/07/2019 08:46, Chris Wilson wrote:
>>> Remove the outer layer cleanup of engine stubs; it no longer tries to
>>
>> Who is "it"?
>
> i915_drv.c
>
>>> preallocate and so is not responsible for either the allocation or free.
>>> By the time we call the cleanup function, we already have cleaned up the
>>> engines.
>>
>> I see:
>>
>> i915_driver_probe
>> {
>> ...
>> ret = i915_driver_early_probe(dev_priv);
>> ...
>> i915_driver_mmio_probe -> intel_engines_init_mmio -> allocates engines
>> ...
>> <later step fails> -> who frees the engines?
>
> The mirror of i915_driver_mmio_probe, which would be
> i915_driver_mmio_release, should be responsible for cleaning up.
So needs to start calling intel_engines_cleanup, or I am still missing
something?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-17 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 7:46 [PATCH] drm/i915: Remove obsolete engine clenaup Chris Wilson
2019-07-17 8:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-07-17 9:54 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-17 13:18 ` [PATCH] " Tvrtko Ursulin
2019-07-17 13:24 ` Chris Wilson
2019-07-17 13:28 ` Tvrtko Ursulin [this message]
2019-07-17 13:27 ` [PATCH] drm/i915: Remove obsolete engine cleanup Chris Wilson
2019-07-17 14:03 ` ✓ Fi.CI.BAT: success for drm/i915: Remove obsolete engine clenaup (rev2) Patchwork
2019-07-17 18:33 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bcbef89-5e9b-e35f-869d-369e2689a33a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox