From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/guc: Release GuC interrupts in i915_guc_submission_disable
Date: Mon, 13 Mar 2017 10:28:34 +0530 [thread overview]
Message-ID: <1e9f34ae-5a84-81e5-94d7-5bd7e6989de4@intel.com> (raw)
In-Reply-To: <20170312125958.GL28427@nuc-i3427.alporthouse.com>
On 3/12/2017 6:29 PM, Chris Wilson wrote:
> On Sat, Mar 11, 2017 at 04:17:34AM -0000, Patchwork wrote:
>> == Series Details ==
>>
>> Series: series starting with [1/3] drm/i915/guc: Release GuC interrupts in i915_guc_submission_disable
>> URL : https://patchwork.freedesktop.org/series/21090/
>> State : success
>>
>> == Summary ==
>>
>> Series 21090v1 Series without cover letter
>> https://patchwork.freedesktop.org/api/1.0/series/21090/revisions/1/mbox/
>>
>> Test kms_pipe_crc_basic:
>> Subgroup hang-read-crc-pipe-b:
>> dmesg-warn -> PASS (fi-byt-j1900)
> Applied, thanks for the quick fix. It is looking much neater now as well
> :)
> -Chris
Thanks Chris.
I feel unmasking of ARAT_EXPIRED is hard coding the behavior with GuC.
Ideally rps enabling should happen post GuC load in reset path like in load time flow.
That way instead of hard coding interrupts to be kept as ARAT_EXPIRED we will be able to derive from bits unmasked by GuC in PMINTRMSK.
So before GuC load, we should be resetting RPS interrupts (making PMINRMSK=~0u) and then derive interrupts to be kept unmasked by Host.
And then enable RPS. Current state is fine as we know GuC isn't using other PM interrupts. (might use some of those in SLPC)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-13 4:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 2:36 [PATCH 1/3] drm/i915/guc: Release GuC interrupts in i915_guc_submission_disable Sagar Arun Kamble
2017-03-11 2:37 ` [PATCH 2/3] drm/i915: s/pm_intr_keep/pm_intrmsk_mbz Sagar Arun Kamble
2017-03-11 2:37 ` [PATCH 3/3] drm/i915/guc: Update rps.pm_intrmsk_mbz in guc_interrupts_capture/release Sagar Arun Kamble
2017-03-11 4:17 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/guc: Release GuC interrupts in i915_guc_submission_disable Patchwork
2017-03-12 12:59 ` Chris Wilson
2017-03-13 4:58 ` Kamble, Sagar A [this message]
2017-03-13 9:47 ` Chris Wilson
2017-03-14 17:42 ` Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e9f34ae-5a84-81e5-94d7-5bd7e6989de4@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox