From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Hogander, Jouni" <jouni.hogander@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: use intel_bo_to_drm_bo in intel_fbdev
Date: Fri, 1 Dec 2023 13:55:01 +0000 [thread overview]
Message-ID: <1f087cb48e0916997cf0eed770c153fecc793acb.camel@intel.com> (raw)
In-Reply-To: <20231115090719.3210079-3-jouni.hogander@intel.com>
On Wed, 2023-11-15 at 11:07 +0200, Jouni Högander wrote:
> We are preparing for Xe driver. I915 and Xe object implementation are
> differing. Do not use i915_gem_object->base directly. Instead use
> intel_bo_to_drm_bo.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c
> b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index b7e4b7830e45..99894a855ef0 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -332,12 +332,12 @@ static bool intel_fbdev_init_bios(struct drm_device *dev,
> continue;
> }
>
> - if (obj->base.size > max_size) {
> + if (intel_bo_to_drm_bo(obj)->size > max_size) {
> drm_dbg_kms(&i915->drm,
> "found possible fb from [PLANE:%d:%s]\n",
> plane->base.base.id, plane->base.name);
> fb = to_intel_framebuffer(plane_state->uapi.fb);
> - max_size = obj->base.size;
> + max_size = intel_bo_to_drm_bo(obj)->size;
> }
> }
>
next prev parent reply other threads:[~2023-12-01 13:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 9:07 [Intel-gfx] [PATCH 0/2] Prepare intel_fbdev for Xe Jouni Högander
2023-11-15 9:07 ` [Intel-gfx] [PATCH 1/2] drm/i915/display: split i915 specific code from intel_fbdev Jouni Högander
2023-12-01 13:53 ` Govindapillai, Vinod
2023-12-01 15:23 ` Hogander, Jouni
2023-11-15 9:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/display: use intel_bo_to_drm_bo in intel_fbdev Jouni Högander
2023-12-01 13:55 ` Govindapillai, Vinod [this message]
2023-12-01 15:31 ` Hogander, Jouni
2023-11-15 12:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fbdev for Xe Patchwork
2023-11-15 12:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-11-15 13:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-16 0:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fbdev for Xe (rev2) Patchwork
2023-11-16 0:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-11-16 0:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-17 5:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-12-01 15:19 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f087cb48e0916997cf0eed770c153fecc793acb.camel@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox