Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: chiachen <luojiazhen@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83
Date: Wed, 20 Oct 2010 14:00:28 +0000 (UTC)
Date: Fri, 22 Oct 2010 13:03:30 +0800	[thread overview]
Message-ID: <201010221303.31698.luojiazhen@gmail.com> (raw)
In-Reply-To: <1278029082-24223-1-git-send-email-airlied@gmail.com>

在 星期五 02 7月 2010 08:04:42,Dave Airlie 写道:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> 
> Since 4bdadb9785696439c6e2b3efe34aa76df1149c83, we've 
been passing
> GFP_MOVABLE where we weren't before caused hibernate on 
Intel hardware
> to results in a lot of memory corruptions on resume.
> 
> [airlied: linus please enhance commit msg if you commit this]
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=13811
> 
> Reported-by: Evengi Golov (in bugzilla)
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> Tested-by: M. Vefa Bicakci <bicave@superonline.com>
> ---
>  drivers/gpu/drm/i915/i915_gem.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c
> b/drivers/gpu/drm/i915/i915_gem.c index 9ded3da..0743858 
100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2239,7 +2239,7 @@ i915_gem_object_get_pages(struct 
drm_gem_object *obj,
>  	mapping = inode->i_mapping;
>  	for (i = 0; i < page_count; i++) {
>  		page = read_cache_page_gfp(mapping, i,
> -					   mapping_gfp_mask (mapping) |
> +					   GFP_HIGHUSER |
>  					   __GFP_COLD |
>  					   gfpmask);
>  		if (IS_ERR(page))
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2010-10-20 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02  0:04 [PATCH] drm/i915: fix hibernation since 4bdadb9785696439c6e2b3efe34aa76df1149c83 Dave Airlie
2010-07-02  0:37 ` Greg KH
2010-07-02  1:39   ` Linus Torvalds
2010-10-20 14:00 ` chiachen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010221303.31698.luojiazhen@gmail.com \
    --to=luojiazhen@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox