From: Liu Xinyun <xinyun.liu@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: fix backlight resets to minium when changing resolution
Date: Wed, 10 Nov 2010 00:42:50 +0800 [thread overview]
Message-ID: <20101109164250.GA8905@woliu-sh> (raw)
It is reported as https://bugs.freedesktop.org/show_bug.cgi?id=29716.
find the regression and here is the fix, maybe ugly.
diff --git a/src/intel_display.c b/src/intel_display.c
index d32224e..4a159bf 100644
--- a/src/intel_display.c
+++ b/src/intel_display.c
@@ -339,6 +339,8 @@ intel_crtc_apply(xf86CrtcPtr crtc)
if (output->crtc != crtc)
continue;
+ /* Turn on any outputs on this crtc that may have been disabled */
+ intel_output_dpms(output, DPMSModeOn);
intel_output = output->driver_private;
output_ids[output_count] =
--------
this regression is caused by this commit. In fact, KMS doesn't not handle
backlight properly as we think. I don't know where to put the code, so I
use above code in xf86-intel-driver to fix this issue.
In fact, KMS initialize mode as DPMSOFF, and X set to it to ON after start.
And if any mode is changed, it will set to 'correct' status: OFF. Thus xrandr can
not change backlight any more. So a better solution shoule be there. Any suggestion?
19c48d3b3f33582baa87a9b3a9189e320e4cea45 is the first bad commit
commit 19c48d3b3f33582baa87a9b3a9189e320e4cea45
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Mon Aug 9 10:13:58 2010 +0100
display: outputs are enabled automatically by KMS
When an output is attached to a crtc and that crtc is enabled, the
output is automatically enabled so we can remove the redundant manual
dpms on.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Regards,
Xinyun
reply other threads:[~2010-11-09 16:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109164250.GA8905@woliu-sh \
--to=xinyun.liu@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox