From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: please revert 869184a675662bddcdf76c5b95665272facff2b8 ASAP
Date: Mon, 6 Dec 2010 14:35:30 -0800 [thread overview]
Message-ID: <20101206143530.32342517@jbarnes-desktop> (raw)
In-Reply-To: <AANLkTi=DauJf52_wDqGC2Enouc+T_oKcWz9ooM-H0vxx@mail.gmail.com>
On Tue, 7 Dec 2010 08:32:49 +1000
Dave Airlie <airlied@gmail.com> wrote:
> On Tue, Dec 7, 2010 at 4:04 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Mon, 29 Nov 2010 20:06:23 +1000
> > Dave Airlie <airlied@gmail.com> wrote:
> >
> >> On Mon, Nov 29, 2010 at 7:44 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >> > On Mon, 29 Nov 2010 16:18:44 +1000, Dave Airlie <airlied@gmail.com> wrote:
> >> >> This commit breaks the eDP panel on the my HP Elitebook 2540p,
> >> >> reverting it brings the panel back to life.
> >> >
> >> > Happy to test the revert just as soon as I work out what the equivalent
> >> > commit is in my tree... ;-)
> >> > -Chris
> >>
> >> oops
> >>
> >> 869184a675662bddcdf76c5b95665272facff2b8
> >>
> >> must have sent the revert commit id locally or something ;-)
> >>
> >> drm/i915/dp: use VBT provided eDP params if available
> >>
> >> Looks like trusting the BIOS is a bad plan, also that commit seems to
> >> do a lot more than just use some VBT values, probably needs more
> >> splitting up from jbarnes.
> >
> > !#$!@!!
> >
> > One day we'll have reliable eDP mode setting, I promise. Time to
> > harass some more people internally about how to get sane values and
> > whether skipping training is generally safe (assuming we use the right
> > values that is!).
>
> I suspect you should split that patch also, it did two things, and I
> wasn't sure which one way the one I wanted.
You mean using the VBT values and avoiding the training? I suppose
those could be split, but for eDP they should amount to the same thing
(but otoh "should" is a big word when talking about eDP).
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2010-12-06 22:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:06 please revert 869184a675662bddcdf76c5b95665272facff2b8 ASAP Dave Airlie
2010-11-29 19:14 ` Chris Wilson
2010-11-29 20:19 ` Dave Airlie
2010-11-30 9:29 ` Chris Wilson
2010-12-09 20:05 ` Joep Daandels
2010-12-09 21:04 ` Jesse Barnes
2010-12-06 18:04 ` Jesse Barnes
2010-12-06 22:32 ` Dave Airlie
2010-12-06 22:35 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206143530.32342517@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox