Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: benjamin.widawsky@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] drm/i915: context support unit test
Date: Tue, 4 Jan 2011 21:10:04 +0100	[thread overview]
Message-ID: <20110104201004.GA3519@viiv.ffwll.ch> (raw)
In-Reply-To: <0d30dc$kk5sgj@orsmga001.jf.intel.com>

On Fri, Dec 31, 2010 at 09:31:23AM +0000, Chris Wilson wrote:
> I'm still leaning towards explicit associate/disassociate ioctls as I
> think that will lead to a simpler userspace API (or at least integrate
> conveniently with the existing libdrm).

I don't like a separate ioctl to associate/disassociate a buffer from a
context: Conceptually there's no way to change that association without an
execbuf call. Doing the book-keeping as a separate, non-atomic ioctl calls
calls for trouble imho.

> ...

> "Minimal, consistent and difficult to misuse."

i.e. violates the "difficult to misuse" paradigm ;) My idea of a special
reloc type is probably not the cleanest (hm, slight understatement here ;)
and could need some improvement. Anyway, I'll wait and see what the real
use-case looks like. My arguments feel too hand-waivy already ...

Cheers, Daniel

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  reply	other threads:[~2011-01-04 20:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-25 22:53 [RFC] drm/i915: context support unit test Ben Widawsky
2010-12-28 22:36 ` Daniel Vetter
2010-12-29  4:03   ` Ben Widawsky
2010-12-30 10:07     ` Daniel Vetter
2010-12-30 11:13       ` Chris Wilson
2010-12-30 12:48         ` Daniel Vetter
2010-12-30 20:21           ` Ben Widawsky
2010-12-31  0:48             ` Ben Widawsky
2010-12-31  9:31               ` Chris Wilson
2011-01-04 20:10                 ` Daniel Vetter [this message]
2011-01-04 20:21                   ` Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110104201004.GA3519@viiv.ffwll.ch \
    --to=daniel@ffwll.ch \
    --cc=benjamin.widawsky@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox