From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
Subject: Re: [PATCH 03/17] drm/i915: Release object along create user fb error path
Date: Fri, 22 Apr 2011 11:21:23 -0700 [thread overview]
Message-ID: <20110422182123.GE27642@bwgnt.jf.intel.com> (raw)
In-Reply-To: <1303420712-6369-4-git-send-email-chris@chris-wilson.co.uk>
On Thu, Apr 21, 2011 at 10:18:18PM +0100, Chris Wilson wrote:
> Reported-by: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@kernel.org
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2183c4d..16f38e4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6582,8 +6582,10 @@ intel_user_framebuffer_create(struct drm_device *dev,
> return ERR_PTR(-ENOENT);
>
> intel_fb = kzalloc(sizeof(*intel_fb), GFP_KERNEL);
> - if (!intel_fb)
> + if (!intel_fb) {
> + drm_gem_object_unreference_unlocked(&obj->base);
> return ERR_PTR(-ENOMEM);
> + }
>
> ret = intel_framebuffer_init(dev, intel_fb, mode_cmd, obj);
> if (ret) {
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
next prev parent reply other threads:[~2011-04-22 18:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 21:18 Pending i915 fixes Chris Wilson
2011-04-21 21:18 ` [PATCH 01/17] drm/i915: Move the irq wait queue initialisation into the ring init Chris Wilson
2011-04-21 22:26 ` Jesse Barnes
2011-04-21 21:18 ` [PATCH 02/17] drm/i915: Disable all outputs early, before KMS takeover Chris Wilson
2011-04-21 21:18 ` [PATCH 03/17] drm/i915: Release object along create user fb error path Chris Wilson
2011-04-22 18:21 ` Ben Widawsky [this message]
2011-04-21 21:18 ` [PATCH 04/17] drm/i915/dp: Be paranoid in case we disable a DP before it is attached Chris Wilson
2011-04-21 21:18 ` [PATCH 05/17] drm/i915/tv: Clear state sense detection for Cantiga Chris Wilson
2011-04-21 23:36 ` Eric Anholt
2011-04-22 5:28 ` Chris Wilson
2011-04-22 21:44 ` Peter Clifton
2011-05-20 9:16 ` Niccolò Belli
2011-05-20 10:00 ` Keith Packard
2011-05-20 13:37 ` Niccolò Belli
2011-04-21 21:18 ` [PATCH 06/17] drm/i915: Check that the plane points to the pipe's framebuffer before enabling Chris Wilson
2011-04-21 21:18 ` [PATCH 07/17] drm/i915: Only enable the plane after setting the fb base (pre-ILK) Chris Wilson
2011-04-21 22:27 ` Jesse Barnes
2011-04-21 21:18 ` [PATCH 08/17] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable Chris Wilson
2011-05-04 19:10 ` Keith Packard
2011-05-04 19:40 ` Chris Wilson
2011-05-04 21:20 ` Keith Packard
2011-05-04 21:59 ` Chris Wilson
2011-04-21 21:18 ` [PATCH 09/17] drm/i915: Simplify return value from intel_get_load_detect_pipe Chris Wilson
2011-04-21 21:18 ` [PATCH 10/17] drm/i915: Propagate failure to set mode for load-detect pipe Chris Wilson
2011-04-21 21:18 ` [PATCH 11/17] drm/i915: Don't store temporary load-detect variables in the generic encoder Chris Wilson
2011-04-21 21:18 ` [PATCH 12/17] drm/i915: Remove unused supported_crtc from intel_load_detect_pipe Chris Wilson
2011-04-21 21:18 ` [PATCH 13/17] drm/i915: Pass the saved adjusted_mode when adding to the load-detect crtc Chris Wilson
2011-04-21 21:18 ` [PATCH 14/17] drm/i915: Remove dead code from intel_get_load_detect_pipe() Chris Wilson
2011-04-21 21:18 ` [PATCH 15/17] drm/i915: Remove dead code from intel_release_load_detect_pipe() Chris Wilson
2011-04-21 21:18 ` [PATCH 16/17] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
2011-04-21 21:18 ` [PATCH 17/17] drm/i915: restore only the mode of this driver on lastclose (v2) Chris Wilson
2011-04-21 21:56 ` Pending i915 fixes Keith Packard
2011-04-21 22:01 ` Dave Airlie
2011-04-22 0:06 ` Keith Packard
2011-04-22 5:33 ` Chris Wilson
2011-04-21 22:40 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422182123.GE27642@bwgnt.jf.intel.com \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox