From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Ian Romanick <idr@freedesktop.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: initialize gen6 rps work queue for Ironlake+
Date: Wed, 18 May 2011 10:22:27 -0700 [thread overview]
Message-ID: <20110518102227.55d69f59@jbarnes-desktop> (raw)
In-Reply-To: <4DD3F5DC.904@freedesktop.org>
On Wed, 18 May 2011 18:37:48 +0200
Ian Romanick <idr@freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/18/2011 06:21 PM, Jesse Barnes wrote:
> > Looks like I didn't merge Ben's RPS work queue stuff correctly with the
> > new IRQ split code (diff was sparse enough that git didn't complain).
> > This should prevent null derefs on ILK+ due to the missing work queue.
>
> Is this actually needed on Ironlake (i.e., gen5)?
>
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
The work queue is only used on gen6, but gen6 and ilk share an irq
handler. I could make the work queue init conditional on gen6 though,
if that's what you're thinking.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-05-18 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 16:21 [PATCH] drm/i915: initialize gen6 rps work queue for Ironlake+ Jesse Barnes
2011-05-18 16:37 ` Ian Romanick
2011-05-18 17:22 ` Jesse Barnes [this message]
2011-05-18 20:42 ` Keith Packard
2011-05-18 20:51 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518102227.55d69f59@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=idr@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox