Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Marcus Lorentzon <marcus.xm.lorentzon@stericsson.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	Alan@freedesktop.org,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [RFC] Updated plane support v3
Date: Tue, 21 Jun 2011 09:13:02 -0700	[thread overview]
Message-ID: <20110621091302.08031ae7@jbarnes-desktop> (raw)
In-Reply-To: <4E005C8B.3030908@stericsson.com>

On Tue, 21 Jun 2011 10:55:39 +0200
Marcus Lorentzon <marcus.xm.lorentzon@stericsson.com> wrote:

> On 06/20/2011 10:11 PM, Jesse Barnes wrote:
> > This version adds both source and dest rect params to the set_plane
> > ioctl, and makes the source fixed point to support hardware that needs
> > it.
> >
> > I haven't changed the name of the SNB implementation yet (per Chris's
> > suggestions) but will before it gets upstream.
> >
> > I'd be interested to see whether these interfaces will work for other
> > hardware, so please take a close look at them and ideally implement them
> > on your hardware to make sure (see my userspace example code from
> > earlier posts if you want something to crib from).
> >
> > Thanks,
> > Jesse
> >
> >    
> Is it possible to position a plane above and below the "normal" crtc 
> framebuffer? Plane z-order is unsigned, and I would assume 0 is default 
> z-order.
> Applications will need to position planes above and below crtc normal 
> framebuffer. Below when using a translucent or color keyed framebuffer, 
> and above if framebuffer is opaque.

I was thinking 0 would be the bottom layer.  But either way we don't
have a way of getting the primary plane z position atm, so it'll be
hard to position a new plane above or below the main plane...  I'm ok
with a signed value here, but the real meaning will be defined by a new
ioctl we use to get plane blending restrictions, z order, and such.

> So maybe add a one liner comment about z-order meaning and make it 
> signed unless ordering should be solved in another way.
> 
> And should it be possible to only define planes with no crtc framebuffer 
> at all? Use case, for example letter boxed video on black background 
> with small UI controls/subtitles. In this case it's not power efficient 
> to have a fullscreen fb with mostly if not all transparent pixels.

A particular driver may be able to expose that somehow, maybe by
allowing clients to define a special fb handle that can be used to
indicate no plane should be bound to the CRTC as the "primary" plane.

-- 
Jesse Barnes, Intel Open Source Technology Center

  parent reply	other threads:[~2011-06-21 16:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 20:11 [RFC] Updated plane support v3 Jesse Barnes
2011-06-20 20:11 ` [PATCH 1/4] drm: add plane support Jesse Barnes
2011-07-21 10:30   ` Joonyoung Shim
2011-07-21 17:14     ` Jesse Barnes
2011-07-25  8:18       ` Joonyoung Shim
2011-07-25 14:57         ` Rob Clark
2011-07-26  4:21           ` Joonyoung Shim
2011-07-22 13:52   ` Rob Clark
2011-07-22 15:30     ` Jesse Barnes
2011-07-22 15:57       ` Rob Clark
2011-07-22 22:18     ` Alan Cox
2011-06-20 20:11 ` [PATCH 2/4] drm: add an fb creation ioctl that takes a pixel format Jesse Barnes
2011-06-20 20:11 ` [PATCH 3/4] drm/i915: rename existing overlay support to "legacy" Jesse Barnes
2011-06-20 20:11 ` [PATCH 4/4] drm/i915: add SNB video sprite support Jesse Barnes
2011-06-21  8:55 ` [RFC] Updated plane support v3 Marcus Lorentzon
2011-06-21  9:12   ` Daniel Vetter
2011-06-21 16:13   ` Jesse Barnes [this message]
2011-06-21 11:21 ` Rob Clark
2011-06-21 13:16   ` Rob Clark
2011-06-21 16:19   ` Jesse Barnes
2011-06-22  1:09     ` Rob Clark
2011-09-19  8:03 ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621091302.08031ae7@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=Alan@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marcus.xm.lorentzon@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox