From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: kicking rings considered harmful
Date: Mon, 3 Oct 2011 10:58:02 +0200 [thread overview]
Message-ID: <20111003085802.GC2812@phenom.ffwll.local> (raw)
In-Reply-To: <20111001230933.11d9ebf5@bwidawsk.net>
On Sat, Oct 01, 2011 at 11:09:33PM -0700, Ben Widawsky wrote:
> On Sat, 01 Oct 2011 20:59:28 -0700
> Eric Anholt <eric@anholt.net> wrote:
>
> > On Sat, 1 Oct 2011 19:15:19 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >
> > > Only do it in the hope of resurrecting the gpu. Disable when reset is
> > > disabled because it seems to tremendously increases our changes to
> > > actually capture an error_state before the system goes all belly-up.
> >
> > This patch needs a better subject, like "Disable stuck semaphore kick when
> > GPU reset is disabled", instead of something suggesting that kicking
> > rings is bad in general and going to be removed by the patch.
>
> I'm in favor of removing the ring kick code. I've never seen it actually work,
> and Chris mentioned something on IRC about how it's no longer quite as
> necessary. I'll let Daniel handle the authoritative response though.
Yeah, just kill the stuck semaphore ring kick code. If we deadlock on
semaphores or something like that, we likely have a massive problem and a
full reset sounds like the best course of action. Otoh I think we need to
retain the kick ring stuck in MI_WAIT code, at least to keep on supporting
old (broken) userspace.
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-10-03 8:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 2:15 [PATCH 0/3] some hangcheck cleanups Ben Widawsky
2011-10-02 2:15 ` [PATCH 1/3] drm/i915: collect per ring page fault info on error Ben Widawsky
2011-10-02 2:15 ` [PATCH 2/3] drm/i915: check acthd for all rings Ben Widawsky
2011-10-03 16:59 ` Ben Widawsky
2011-10-02 2:15 ` [PATCH 3/3] drm/i915: kicking rings considered harmful Ben Widawsky
2011-10-02 3:59 ` Eric Anholt
2011-10-02 6:09 ` Ben Widawsky
2011-10-03 8:58 ` Daniel Vetter [this message]
2011-10-03 9:11 ` [PATCH 0/3] some hangcheck cleanups Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003085802.GC2812@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox