From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Simon Que <sque@chromium.org>
Cc: intel-gfx@lists.freedesktop.org, olofj@chromium.org
Subject: Re: [PATCH] drivers: i915: Default max backlight brightness value
Date: Mon, 31 Oct 2011 20:32:12 +0000 [thread overview]
Message-ID: <20111031203212.GA10870@srcf.ucam.org> (raw)
In-Reply-To: <1318636017-14568-1-git-send-email-sque@chromium.org>
On Fri, Oct 14, 2011 at 04:46:57PM -0700, Simon Que wrote:
Sorry, I thought I'd replied to this already. Sorry about that.
> +static u32 intel_panel_get_default_backlight_period(struct drm_device *dev)
> +{
> + /* The default number of clock cycles in one backlight PWM period. */
> + return 0x1000;
I'm uncomfortable with just hardcoding this, especially given that the
comment you're removing implies that it's possible to infer the correct
value from other GPU values. If this does vary between machines then
simply hardcoding it now isn't really any better than the existing error
path - it might make things better for some systems, but it has the
potential to break hardware that expects a different value and no longer
generates an error in that case.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-10-31 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 23:46 [PATCH] drivers: i915: Default max backlight brightness value Simon Que
2011-10-25 22:52 ` Simon Que
2011-10-31 20:02 ` Simon Que
2011-10-31 20:32 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031203212.GA10870@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=olofj@chromium.org \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox