From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible
Date: Wed, 16 Nov 2011 08:46:32 -0800 [thread overview]
Message-ID: <20111116084632.50ff7cde@jbarnes-desktop> (raw)
In-Reply-To: <CAKMK7uGvvib3Qc3T-+7+83v3_4VdAUL76mBW3AFv80xUnTqkXw@mail.gmail.com>
On Wed, 16 Nov 2011 17:05:50 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Nov 14, 2011 at 21:22, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > To save power when the sprite is full screen, we can disable the primary
> > plane on the same pipe. Track the sprite status and enable/disable the
> > primary opportunistically.
> >
> > Signed-off-by: Jesse Barnes
>
> Imo the indirection is overkill because afaics there's no difference.
> And in my experience this will only get in the way when later hw
> _really_ needs some abstraction (*cough* intel_ringbuffer.c *cough*.
> Can we just kill it?
Yeah I can make ivb and snb share at least (and probably ilk), but I
*do* have code coming that needs the separation. (At least I'm pretty
sure; I'll remove the abstraction if it turns out I don't need it.)
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-11-16 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 20:22 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v2 Jesse Barnes
2011-11-14 20:22 ` [PATCH 2/3] drm/i915: add destination color key support Jesse Barnes
2011-11-16 16:10 ` Daniel Vetter
2011-11-16 16:48 ` Jesse Barnes
2011-11-14 20:22 ` [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
2011-11-16 16:05 ` Daniel Vetter
2011-11-16 16:46 ` Jesse Barnes [this message]
2011-11-16 16:01 ` [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v2 Daniel Vetter
2011-11-18 0:53 ` Lan, Hai
2011-12-07 20:11 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2011-12-07 20:29 Plane support for SNB and IVB Jesse Barnes
2011-12-07 20:29 ` [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
2011-12-12 22:17 ` Daniel Vetter
2011-11-14 19:47 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v2 Jesse Barnes
2011-11-14 19:47 ` [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
2011-11-08 21:19 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support Jesse Barnes
2011-11-08 21:19 ` [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116084632.50ff7cde@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox