From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: add destination color key support
Date: Mon, 12 Dec 2011 23:14:46 +0100 [thread overview]
Message-ID: <20111212221445.GC6832@phenom.ffwll.local> (raw)
In-Reply-To: <1323289763-1963-3-git-send-email-jbarnes@virtuousgeek.org>
On Wed, Dec 07, 2011 at 12:29:22PM -0800, Jesse Barnes wrote:
> Add new ioctls for getting and setting the current destination color
> key. This allows for simple overlay display control by matching a color
> key value in the primary plane before blending the overlay on top.
>
> v2: remove unnecessary mutex acquire/release around reg accesses
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
[snip]
> +/* Set the destination color key on a given sprite */
> +struct drm_intel_set_sprite_destkey {
> + __u32 plane_id;
> + __u32 value;
> +};
> +
> +/* Get the current destination color key on a given sprite */
> +struct drm_intel_get_sprite_destkey {
> + __u32 plane_id;
> + __u32 value;
> +};
As explained in my top-reply, I think we want a __u32 flags here to
enable the colorkey (and maybe switch between dst/src color key). Nothing
else to complain about here.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-12-12 22:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 20:29 Plane support for SNB and IVB Jesse Barnes
2011-12-07 20:29 ` [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v5 Jesse Barnes
2011-12-12 21:56 ` Daniel Vetter
2011-12-13 19:46 ` Jesse Barnes
2011-12-13 21:11 ` Jesse Barnes
2011-12-07 20:29 ` [PATCH 2/3] drm/i915: add destination color key support Jesse Barnes
2011-12-12 22:14 ` Daniel Vetter [this message]
2011-12-07 20:29 ` [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
2011-12-12 22:17 ` Daniel Vetter
2011-12-08 2:58 ` Plane support for SNB and IVB Hai Lan
2011-12-12 21:21 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2011-11-14 20:22 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v2 Jesse Barnes
2011-11-14 20:22 ` [PATCH 2/3] drm/i915: add destination color key support Jesse Barnes
2011-11-16 16:10 ` Daniel Vetter
2011-11-16 16:48 ` Jesse Barnes
2011-11-14 19:47 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v2 Jesse Barnes
2011-11-14 19:47 ` [PATCH 2/3] drm/i915: add destination color key support Jesse Barnes
2011-11-08 21:19 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support Jesse Barnes
2011-11-08 21:19 ` [PATCH 2/3] drm/i915: add destination color key support Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212221445.GC6832@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox