From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Ted Phelps <phelps@gnusto.com>,
Peter <pab1612@gmail.com>, Lukas Hejtmanek <xhejtman@fi.muni.cz>,
Andrew Lutomirski <luto@mit.edu>
Subject: Re: [PATCH 2/2] drm/i915: By default, enable RC6 on IVB and SNB when reasonable
Date: Tue, 13 Dec 2011 03:45:58 +0000 [thread overview]
Message-ID: <20111213034558.GA26750@srcf.ucam.org> (raw)
In-Reply-To: <1323474829-2501-3-git-send-email-keithp@keithp.com>
On Fri, Dec 09, 2011 at 03:53:49PM -0800, Keith Packard wrote:
> RC6 should always work on IVB, and should work on SNB whenever IO
> remapping is disabled. RC6 never works on Ironlake. Make the default
> value for the parameter follow these guidelines. Setting the value
> to either 0 or 1 will force the specified behavior.
I still don't like this. We're in a situation where we clearly have to
disable one feature or the other on SNB - but we're disabling the one
that's going to be useful to a large number of people, and leaving the
niche feature enabled. If we're going to merge this then let's turn off
iommu on SNB by default.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-12-13 3:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 18:15 [PATCH 0/8] misc fixes for 3.2 Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 1/8] drm/i915: there is no pipe CxSR on ironlake Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 2/8] drm: give up on edid retries when i2c bus is not responding Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 3/8] drm/i915: prevent division by zero when asking for chipset power Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 4/8] drm/i915: fix typo in function name Eugeni Dodonov
2012-01-16 22:26 ` Daniel Vetter
2011-11-28 18:15 ` [PATCH 5/8] platform/x86: fix typos in function comments Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 6/8] drm/i915: enable semaphores on per-device defaults Eugeni Dodonov
2011-11-28 18:45 ` Daniel Vetter
2011-12-10 0:02 ` Keith Packard
2011-12-10 1:05 ` [PATCH] " Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 7/8] drm/i915: allow per-device fbc to work with default settings Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 8/8] drm/i915: enable rc6 by default on IVB onwards Eugeni Dodonov
2011-11-28 19:05 ` Daniel Vetter
2011-11-29 0:24 ` [PATCH] " Eugeni Dodonov
2011-11-19 6:41 ` [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable Keith Packard
2011-11-19 7:37 ` Kenneth Graunke
2011-11-19 9:07 ` Eugeni Dodonov
2011-11-19 9:25 ` Eugeni Dodonov
2011-11-19 18:32 ` Keith Packard
2011-11-20 21:19 ` Eugeni Dodonov
2011-11-22 20:15 ` Matthew Garrett
2011-11-22 20:46 ` Eugeni Dodonov
2011-11-22 20:51 ` Matthew Garrett
2011-11-23 3:31 ` Keith Packard
2011-11-23 10:26 ` Daniel Vetter
2011-11-23 14:01 ` David Woodhouse
2011-11-23 14:39 ` Daniel Vetter
2011-11-23 15:03 ` David Woodhouse
2011-11-23 15:31 ` Daniel Vetter
2011-11-23 15:36 ` David Woodhouse
2011-11-23 15:46 ` Daniel Vetter
2011-11-23 15:41 ` Daniel Vetter
2011-11-23 15:43 ` David Woodhouse
2011-11-23 20:35 ` Daniel Vetter
2011-11-23 18:42 ` [PATCH] iommu: export no_iommu and dmar_disabled symbols Eugeni Dodonov
2011-11-23 20:36 ` [Intel-gfx] " David Woodhouse
2011-11-23 20:48 ` Keith Packard
2011-12-09 23:53 ` drm/i915: Enabling RC6 where possible Keith Packard
2011-12-09 23:53 ` [PATCH 1/2] iommu: Export intel_iommu_enabled to signal when iommu is in use Keith Packard
2011-12-09 23:53 ` [PATCH 2/2] drm/i915: By default, enable RC6 on IVB and SNB when reasonable Keith Packard
2011-12-13 3:45 ` Matthew Garrett [this message]
2011-11-29 0:30 ` [PATCH] drm/i915: enable rc6 by default on IVB onwards Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213034558.GA26750@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=pab1612@gmail.com \
--cc=phelps@gnusto.com \
--cc=xhejtman@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox