From: Cyril Brulebois <kibi@debian.org>
To: Eugeni Dodonov <eugeni.dodonov@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: simplify pipe checking
Date: Sun, 8 Jan 2012 03:01:12 +0100 [thread overview]
Message-ID: <20120108020112.GC1531@mraw.org> (raw)
In-Reply-To: <1325986835-12717-1-git-send-email-eugeni.dodonov@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1210 bytes --]
Eugeni Dodonov <eugeni.dodonov@intel.com> (07/01/2012):
> This is also handled by i915_reg.h, so just reuse this trick to reduce
> universe enthropy.
entropy.
Besides that:
Reviewed-by: Cyril Brulebois <kibi@debian.org>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/i915_suspend.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c
> index 7886e4f..c0b945c 100644
> --- a/drivers/gpu/drm/i915/i915_suspend.c
> +++ b/drivers/gpu/drm/i915/i915_suspend.c
> @@ -28,6 +28,7 @@
> #include "drm.h"
> #include "i915_drm.h"
> #include "intel_drv.h"
> +#include "i915_reg.h"
>
> static bool i915_pipe_enabled(struct drm_device *dev, enum pipe pipe)
> {
> @@ -35,7 +36,7 @@ static bool i915_pipe_enabled(struct drm_device *dev, enum pipe pipe)
> u32 dpll_reg;
>
> if (HAS_PCH_SPLIT(dev))
> - dpll_reg = (pipe == PIPE_A) ? _PCH_DPLL_A : _PCH_DPLL_B;
> + dpll_reg = PCH_DPLL(pipe);
> else
> dpll_reg = (pipe == PIPE_A) ? _DPLL_A : _DPLL_B;
>
Mraw,
KiBi.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-01-08 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 1:40 [PATCH 1/2] drm/i915: simplify pipe checking Eugeni Dodonov
2012-01-08 1:40 ` [PATCH 2/2] drm/i915: handle 3rd pipe Eugeni Dodonov
2012-01-08 2:01 ` Cyril Brulebois [this message]
2012-01-16 20:28 ` [PATCH 1/2] drm/i915: simplify pipe checking Daniel Vetter
2012-01-17 10:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120108020112.GC1531@mraw.org \
--to=kibi@debian.org \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox