From: Daniel Vetter <daniel@ffwll.ch>
To: Sateesh Kavuri <sateesh.kavuri@intel.com>
Cc: intel-gfx@lists.freedesktop.org, xorg-devel@lists.x.org
Subject: Re: [PATCH] Android port of intel-gpu-tools
Date: Tue, 10 Jan 2012 13:47:52 +0100 [thread overview]
Message-ID: <20120110124752.GE3979@phenom.ffwll.local> (raw)
In-Reply-To: <1326170701-22099-1-git-send-email-sateesh.kavuri@intel.com>
On Tue, Jan 10, 2012 at 10:15:01AM +0530, Sateesh Kavuri wrote:
> Added support for Android. Changes include fixes for compilation issues
> related to Android using an older version of GCC compiler (ver 4.3.3)
> while the latest version of intel-gpu-tools confirms to GCC ver 4.5.2
> (C99 standard functions), using functions like getline(). Fixed such
> functions, header dependencies for android and added an Android.mk file.
>
> signed-off-by: Sateesh Kavuri <sateesh.kavuri@intel.com>
A few comments
- It looks like you need a completely separate makefile for android. Is
there no way to let the automake tools generate that somehow? Because
this simply won't scale.
- There's too much ANDRIOD #ifdef'ery in the code. Either switch to a
construct that works on all platforms or extract things into a little
helper functions (like the get_total_ram helper that has recently been
ported to Solaris).
- You don't seem to touch the testsuite, and I think you want it on
Andriod, too.
Added xorg-devel to cc, maybe someone else has already tried this with a
different package, my buildsystem fu is not up to this.
Yours, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-10 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 4:45 [PATCH] Android port of intel-gpu-tools Sateesh Kavuri
2012-01-10 12:47 ` Daniel Vetter [this message]
2012-01-16 18:25 ` Chad Versace
2012-01-16 18:36 ` Daniel Vetter
2012-01-16 18:53 ` Chad Versace
[not found] ` <4F147225.3000604-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2012-01-16 19:52 ` [Intel-gfx] " Daniel Stone
2012-01-16 19:43 ` Eugeni Dodonov
2012-01-10 15:03 ` Adam Jackson
2012-01-10 16:50 ` Kavuri, Sateesh
2012-01-16 17:58 ` Chad Versace
2012-01-11 7:54 ` Kenneth Graunke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110124752.GE3979@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sateesh.kavuri@intel.com \
--cc=xorg-devel@lists.x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox