From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
Subject: Re: [PATCH] drm/i915: Mask the ring->head offset using the ring->size
Date: Tue, 17 Jan 2012 11:59:27 +0100 [thread overview]
Message-ID: <20120117105927.GI4093@phenom.ffwll.local> (raw)
In-Reply-To: <1320793992-2891-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, Nov 08, 2011 at 11:13:12PM +0000, Chris Wilson wrote:
> Rather than relying on the hardware to do this correctly, we can
> trivially do it ourselves.
>
> This fixes a very reliable crash on d-i-n with all bits enabled during a
> cairo-trace replay. The symptoms of the crash is that we continue to
> write commands into the render ring buffer past the active head
> position, leading to undefined operations.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@kernel.org
I guess this is just the usual "snb doesn't like being pushed to hard bug"
resulting in random crashes with confusing error_states. So I think I'll
drop this. Correct?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-17 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 23:13 [PATCH] drm/i915: Mask the ring->head offset using the ring->size Chris Wilson
2012-01-17 10:59 ` Daniel Vetter [this message]
2012-01-17 11:14 ` Chris Wilson
2012-02-08 12:49 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117105927.GI4093@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox