From: Daniel Vetter <daniel@ffwll.ch>
To: Keith Packard <keithp@keithp.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: fixup assert_pipe to take the pipe A quirk into account
Date: Mon, 23 Jan 2012 20:40:27 +0100 [thread overview]
Message-ID: <20120123194027.GC5998@phenom.ffwll.local> (raw)
In-Reply-To: <864nvojquh.fsf@sumi.keithp.com>
On Sat, Jan 21, 2012 at 08:36:38PM -0800, Keith Packard wrote:
> On Sun, 22 Jan 2012 01:36:48 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > This was completely spamming dmesg on my i855gm.
>
> This comes from intel_disable_pll, which wants to turn the pll off, but
> if the pipe is still active, it won't be able to. This seems bad to me.
I honestly can't reconcile your comment with the code&patch. Afaics
- the pll disable code checks for the pipe a quirk and does an early exit
before mucking around with the hw and calling assert_pipe.
- assert_pipe only does a WARN and the patch only changes whether we hit
that WARN. All reg reads/writes should be unchanged.
- the backtrace I'm seeing goes through crtc_disable.
Yours, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-23 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 0:36 [PATCH] drm/i915: fixup assert_pipe to take the pipe A quirk into account Daniel Vetter
2012-01-22 4:36 ` Keith Packard
2012-01-23 19:40 ` Daniel Vetter [this message]
2012-01-24 18:24 ` Jesse Barnes
2012-01-24 18:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123194027.GC5998@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox