Re: [PATCH 05/43] drm/i915: collect more per ring error state

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Dec 14, 2011 at 04:43:40PM -0200, Eugeni Dodonov wrote:
> On Wed, Dec 14, 2011 at 10:57, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> 
> > Based on a patch by Ben Widawsky, but with different colors
> > for the bikeshed.
> >
> > In contrast to Ben's patch this one doesn't add the fault regs.
> > Afaics they're for the optional page fault support which
> > - we're not enabling
> > - and which seems to be unsupported by the hw team. Recent bspec
> >  lacks tons of information about this that the public docs released
> >  half a year back still contain.
> >
> > Also dump ring HEAD/TAIL registers - I've recently seen a few
> > error_state where just guessing these is not good enough.
> >
> > v2: Also dump INSTPM for every ring.
> >
> > v3: Fix a few really silly goof-ups spotted by Chris Wilson.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48