Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Bahmann <helge.bahmann@secunet.com>
To: intel-gfx@lists.freedesktop.org
Cc: hcb@chaoticmind.net
Subject: Thinkpad T420 and single/dual channel lvds
Date: Wed, 14 Mar 2012 13:37:14 +0100	[thread overview]
Message-ID: <201203141337.14798.helge.bahmann@secunet.com> (raw)

Hi everyone,

Booting a Thinkpad T420 with the lid closed results and opening it subsequently results in an 
unusable picture on the panel (and no amount of resetting makes it usable): The even pixels show 
the nominal content of the framebuffer (with the right half missing) whlie the odd pixels show a 
red-/blueish flicker.

A little bit of investigation revealed that with the lid closed on boot, the panel ends up driven in 
lvds single channel mode, which the panel probably does not like. It appears that the i915 driver 
relies on the BIOS setting up the PCH_LVDS register for dual channel and will otherwise not ever 
consider switching.

While the following hack makes my display work, it is quite obviously not the right thing to do -- 
could you investigate if there is a "proper" way to determine whether the panel is supposed to be 
driven dual channel?

Best regards
Helge

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f851db7..2e51dc3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -364,8 +364,8 @@ static const intel_limit_t *intel_ironlake_limit(struct drm_crtc *crtc,
 	const intel_limit_t *limit;
 
 	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS)) {
-		if ((I915_READ(PCH_LVDS) & LVDS_CLKB_POWER_MASK) ==
-		    LVDS_CLKB_POWER_UP) {
+		if (1 || ((I915_READ(PCH_LVDS) & LVDS_CLKB_POWER_MASK) ==
+		    LVDS_CLKB_POWER_UP)) {
 			/* LVDS dual channel */
 			if (refclk == 100000)
 				limit = &intel_limits_ironlake_dual_lvds_100m;

             reply	other threads:[~2012-03-14 13:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 12:37 Helge Bahmann [this message]
2012-03-14 14:45 ` Thinkpad T420 and single/dual channel lvds Adam Jackson
2012-03-14 16:44   ` Takashi Iwai
2012-03-14 18:09     ` Adam Jackson
2012-03-15 13:15       ` Takashi Iwai
2012-03-15 13:25         ` Chris Wilson
2012-03-15 13:30           ` Takashi Iwai
2012-03-15 14:42             ` Takashi Iwai
2012-03-16 15:33               ` Rodrigo Vivi
2012-03-16 19:55               ` Adam Jackson
2012-03-16 20:29                 ` Takashi Iwai
2012-03-18 17:50                   ` Daniel Vetter
2012-03-18 18:01                     ` Andreas Heider
2012-03-18 20:26                       ` Takashi Iwai
2012-03-18 20:24                     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203141337.14798.helge.bahmann@secunet.com \
    --to=helge.bahmann@secunet.com \
    --cc=hcb@chaoticmind.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox