From: Seth Forshee <seth.forshee@canonical.com>
To: Akio Idehara <zbe64533@gmail.com>
Cc: chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org,
mjg59@srcf.ucam.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] xf86-video-intel: Add support for toshiba backlight interface
Date: Wed, 14 Mar 2012 09:57:40 -0500 [thread overview]
Message-ID: <20120314145740.GA8693@ubuntu-macmini> (raw)
In-Reply-To: <1331735859-6337-1-git-send-email-zbe64533@gmail.com>
On Wed, Mar 14, 2012 at 11:37:39PM +0900, Akio Idehara wrote:
> xfce4-power-manager cannot control backlight brightness via
> toshiba backlight sysfs interface.
> The reason is that xf86-video-intel doesn't treat it.
> This patch adds support for toshiba backlight sysfs interface.
>
> This was tested on a Toshiba Portege R500.
>
> Signed-off-by: Akio Idehara <zbe64533@gmail.com>
This isn't a good idea. On many (probably most) Toshibas the platform
backlight interface is read-only. I think this patch will break more
machines than it fixes.
I have a patch for toshiba_acpi that (among other things) makes it only
register the backlight device if it can be written. I've just been
sitting on it though because I haven't been able to get anyone with a
read/write backlight interface to test it. If you'd be willing to help
with testing then I can work on getting that patch into the kernel, then
I wouldn't object to your patch.
Seth
next prev parent reply other threads:[~2012-03-14 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 14:37 [PATCH] xf86-video-intel: Add support for toshiba backlight interface Akio Idehara
2012-03-14 14:57 ` Seth Forshee [this message]
2012-03-15 13:20 ` Akio Idehara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314145740.GA8693@ubuntu-macmini \
--to=seth.forshee@canonical.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=zbe64533@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox