Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: Ben Widawsky <ben@bwidawsk.net>,
	Arjan van de Ven <arjan@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add rc6 residency times to debugfs
Date: Sun, 25 Mar 2012 01:01:10 +0100	[thread overview]
Message-ID: <20120325000110.GC18786@phenom.ffwll.local> (raw)
In-Reply-To: <20120324145801.GB7563@phenom.ffwll.local>

On Sat, Mar 24, 2012 at 03:58:01PM +0100, Daniel Vetter wrote:
> On Fri, Mar 23, 2012 at 01:43:22PM -0300, Eugeni Dodonov wrote:
> > On Thu, Mar 22, 2012 at 22:42, Ben Widawsky <ben@bwidawsk.net> wrote:
> > 
> > > RC6 residency should be in intervals of 1.28us, and the counter wraps.
> > > Here is an example using awk to get the RC6 and RC6+ residency in
> > > seconds, since boot.
> > >
> > > cat /sys/kernel/debug/dri/0/i915_drpc_info  | grep residency | awk -F':'
> > > -F' '  '{print $5 * 1.28 / 1000000}'
> > >
> > > This is primarily for QA, but has other applications as well.
> > >
> > 
> > Note that we already have this in intel_reg_dumper as well, since
> > http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/commit/?id=47a5bc505cb972cc94f1fbd9882d4e5c2e72ac43
> > .
> > 
> > But if it makes sense to include it into kernel as well, why not?
> > 
> > Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> 
> Queued for -next, thanks for the patch and review.

Unqueued after some irc discussion with Ben, looks like we don't yet fully
understand how this works (and at least an rc6pp reg seems to be missing).
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

      reply	other threads:[~2012-03-25  0:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23  1:42 [PATCH] drm/i915: add rc6 residency times to debugfs Ben Widawsky
2012-03-23 16:43 ` Eugeni Dodonov
2012-03-23 18:44   ` Ben Widawsky
2012-03-24 14:58   ` Daniel Vetter
2012-03-25  0:01     ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120325000110.GC18786@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=arjan@linux.intel.com \
    --cc=ben@bwidawsk.net \
    --cc=eugeni@dodonov.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox