From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@kernel.org
Subject: Re: [PATCH] drm/i915: quirk away broken OpRegion VBT
Date: Wed, 28 Mar 2012 12:35:50 -0700 [thread overview]
Message-ID: <20120328123550.28e6689a@jbarnes-desktop> (raw)
In-Reply-To: <1332630192_79110@CP5-2952>
[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]
On Sat, 24 Mar 2012 23:03:08 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Sat, 24 Mar 2012 23:51:30 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Somehow the BIOS manages to screw things up when copying the VBT
> > around, because the one we scrap from the VBIOS rom actually works.
> >
> > Cc: stable@kernel.org
> > Tested-by: Markus Heinz <markus.heinz@uni-dortmund.de>
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=28812
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> That completely disproves my theory that the BIOS writers that went to
> the extra trouble to implement the OpRegion specification would be more
> likely to get it right and to make the information stored there accurate.
>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
On some platforms OpRegion is the *only* way to get the VBT
reasonably... but quirking around broken ones is fine (though I suspect
we're not doing something right; the OpRegion VBT ought to be fine).
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2012-03-28 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 22:51 [PATCH] drm/i915: quirk away broken OpRegion VBT Daniel Vetter
2012-03-24 23:03 ` Chris Wilson
2012-03-26 18:54 ` Rodrigo Vivi
2012-03-28 19:35 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328123550.28e6689a@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox