From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: extract intel_enable_rc6()
Date: Wed, 28 Mar 2012 17:30:10 -0700 [thread overview]
Message-ID: <20120328173010.13ec19d9@bwidawsk.net> (raw)
In-Reply-To: <20120325121059.GA5909@phenom.ffwll.local>
On Sun, 25 Mar 2012 14:10:59 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, Mar 24, 2012 at 07:09:45PM -0700, Ben Widawsky wrote:
> > nice to have elsewhere
> >
> > CC: Eugeni Dodonov <eugeni.dodonov@intel.com>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> I was momentarily confused with this commit message, until I've
> noticed that you need this in the next patch (I've assumed Eugeni
> needs to for something). So please slightly elaborate on the reasons
> for this.
>
> Also I've wondered whether we shouldn't filter the individual rc6
> levels? Or are all counters sane once you enable at least one of the
> rc6 levels? -Daniel
The only insane counter is rc6 (p and pp work as I would expect). Rc6
seems to always have some random value in it. Eugeni's theory is the
BIOS initializes RC6 always, and that's where that value comes from.
The register is read only, unfortunately.
next prev parent reply other threads:[~2012-03-29 0:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 2:09 [PATCH 1/3] drm/i915: add rc6 residency times to debugfs Ben Widawsky
2012-03-25 2:09 ` [PATCH 2/3] drm/i915: extract intel_enable_rc6() Ben Widawsky
2012-03-25 12:10 ` Daniel Vetter
2012-03-29 0:30 ` Ben Widawsky [this message]
2012-03-25 2:09 ` [PATCH 3/3] drm/i915: rc6 in sysfs Ben Widawsky
2012-03-25 2:14 ` Ben Widawsky
2012-03-25 12:15 ` Daniel Vetter
2012-03-29 0:31 ` Ben Widawsky
2012-03-25 2:09 ` [PATCH 1/2] build: make sure we have asprintf Ben Widawsky
2012-03-25 2:09 ` [PATCH 2/2] tests: rc6 residency test Ben Widawsky
2012-03-25 12:21 ` Daniel Vetter
2012-03-25 2:22 ` [PATCH 1/3] drm/i915: add rc6 residency times to debugfs Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2012-03-26 0:33 [PATCH v2 " Ben Widawsky
2012-03-26 0:33 ` [PATCH 2/3] drm/i915: extract intel_enable_rc6() Ben Widawsky
2012-03-26 9:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328173010.13ec19d9@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox