From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/7] drm/i915: implement w/a for incorrect guarband clipping
Date: Wed, 11 Apr 2012 00:20:11 +0200 [thread overview]
Message-ID: <20120410222011.GP4115@phenom.ffwll.local> (raw)
In-Reply-To: <20120410221352.GE21080@bolo_yeung.jf.intel.com>
On Tue, Apr 10, 2012 at 03:13:52PM -0700, Ben Widawsky wrote:
> On Sat, Mar 31, 2012 at 11:22:01AM +0200, Daniel Vetter wrote:
> > According to Bsepc, this should be set by default, but isn't. See vo1c.4
> > "Render Engine Command Streamer", Section 1.1.14.3 "3D_CHICKEN3"
> >
> > Bspec also says that we always need to set all mask bits.
> I think this deserves to be a comment in the code itself. That really
> made me say WTF when looking at the patch.
Agreed, I'll add a comment to that effect.
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-04-10 22:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 9:21 [PATCH 0/7] A set of SNB workarounds Daniel Vetter
2012-03-31 9:21 ` [PATCH 1/7] drm/i915: implement ColorBlt w/a Daniel Vetter
2012-03-31 10:54 ` Chris Wilson
2012-03-31 13:15 ` Chris Wilson
2012-04-10 9:08 ` Michael Groh
2012-04-10 9:54 ` Paul Menzel
2012-04-10 22:24 ` Ben Widawsky
2012-04-11 10:18 ` Daniel Vetter
2012-03-31 9:21 ` [PATCH 2/7] drm/i915: implement a media hang w/a Daniel Vetter
2012-04-10 21:30 ` Ben Widawsky
2012-04-10 21:34 ` Ben Widawsky
2012-04-10 21:36 ` Ben Widawsky
2012-03-31 9:21 ` [PATCH 3/7] drm/i915: set w/a bit for snb pagefaults Daniel Vetter
2012-04-10 21:46 ` Ben Widawsky
2012-03-31 9:22 ` [PATCH 4/7] drm/i915: properly set ppgtt cacheability on snb Daniel Vetter
2012-04-10 22:11 ` Ben Widawsky
2012-04-10 22:27 ` Daniel Vetter
2012-04-10 22:35 ` Ben Widawsky
2012-03-31 9:22 ` [PATCH 5/7] drm/i915: implement w/a for incorrect guarband clipping Daniel Vetter
2012-04-10 22:13 ` Ben Widawsky
2012-04-10 22:20 ` Daniel Vetter [this message]
2012-03-31 9:22 ` [PATCH 6/7] drm/i915: implement async flush w/a Daniel Vetter
2012-03-31 10:52 ` Chris Wilson
2012-04-10 9:53 ` Paul Menzel
2012-04-10 22:22 ` Ben Widawsky
2012-03-31 9:22 ` [PATCH 7/7] drm/i915: set stc evict disable lra evict w/a Daniel Vetter
2012-04-10 22:31 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410222011.GP4115@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox